WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#8869 closed defect (bug) (fixed)

Update Inline Documentation for get_gmt_from_date()

Reported by: CharlesClarkson Owned by:
Milestone: 2.7.1 Priority: lowest
Severity: trivial Version: 2.7
Component: Comments Keywords: phpdoc has-patch commit
Focuses: Cc:

Description

Edited inline documentation for get_gmt_from_date() in formatting.php.

Attachments (1)

formatting.diff (629 bytes) - added by CharlesClarkson 6 years ago.

Download all attachments as: .zip

Change History (10)

@CharlesClarkson6 years ago

comment:1 follow-ups: @jacobsantos6 years ago

  • Keywords phpdoc has-patch commit added; phpDoc inline documentation removed

Eh? The patch appears to be based off of a personal repository with WordPress in it. Will the patch still work with the official one?

comment:2 @jacobsantos6 years ago

There is also a ticket for all of the Inline Documentation, but no one seems to understand that it exists, because no one besides me has ever used it.

comment:3 in reply to: ↑ 1 @mrmist6 years ago

Replying to jacobsantos:

Eh? The patch appears to be based off of a personal repository with WordPress in it. Will the patch still work with the official one?

It does apply correctly against trunk (10369) with a little massaging.

comment:4 in reply to: ↑ 1 @CharlesClarkson6 years ago

Replying to jacobsantos:

Eh? The patch appears to be based off of a personal repository with WordPress in it. Will the patch still work with the official one?

This is my first time using SVN and WordPress Trac. I first diffed the formatting.php file against trunk and found a lot of code changes. Then I updated the file in the SVN and received a modified file.

According to the logs it is revision #10355 committed by user: azzozz.

Should I checkout a particular version instead of trunk?

I really need to know. I will probably be adding a lot of these changes.

comment:5 @DD326 years ago

Eh? The patch appears to be based off of a personal repository with WordPress in it. Will the patch still work with the official one?

Nah.. Just looks like a non-svn tool used to create the diff, Common amongst some svn clients which use external diffing applications. Patch'll apply fine, most applications are smart enough to work out that the full path is in the diff and try and locate the file itself..

comment:6 @jacobsantos6 years ago

See #8805 for where you can put the future patches, in the case that future patches are in the timeframe of 2.8.

comment:7 @westi6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10370]) Update phpdoc for get_gmt_from_date(). Fixes #8869 for trunk

comment:8 @westi6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 @westi6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10371]) Update phpdoc for get_gmt_from_date(). Fixes #8869 for 2.7.x

Note: See TracTickets for help on using tickets.