Make WordPress Core

Opened 20 years ago

Closed 18 years ago

#887 closed defect (bug) (fixed)

Smilies with apostrophes are Smarty-ified before being parsed (like :'( )

Reported by: sethkinast's profile sethkinast Owned by:
Milestone: Priority: normal
Severity: minor Version: 1.5
Component: General Keywords:
Focuses: Cc:

Description

As seen here: http://sethkinast.com/blog/archive/2005/02/14/happy-singles-awareness-day/#comment-2177

The function that turns straight apostrophes into forward and back apostrophes fires before the smiley parser. Smilies should be parsed first so things like the crying face :'( work.

Attachments (1)

default-filters.php.diff (428 bytes) - added by sethkinast 20 years ago.

Download all attachments as: .zip

Change History (6)

#1 @sethkinast
20 years ago

  • Patch set to No

#2 @MC_incubus
20 years ago

Are you using a custom list of smilies by setting $wpsmiliestrans in the config file?

None of WordPress's built in smilies contain apostrophes. The shortcut for the crying emoticon is :cry:

See here for a list of all of the emoticons:
http://txfx.net/2004/08/18/wordpress-smilies/

#3 @sethkinast
20 years ago

Indeed, it's a custom list.

#4 @MC_incubus
20 years ago

  • Patch changed from No to Yes
  • Resolution changed from 10 to 20

Bumped priority for convert_smilies up to 9 in the patch I uploaded.

Thanks for reporting the issue, Seth.

#5 @filosofo
18 years ago

  • Status changed from new to closed

fixed at or before 2.0.3

Note: See TracTickets for help on using tickets.