WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#8903 closed defect (bug) (duplicate)

wp_tag_cloud invasive styling

Reported by: Appletalk Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.7
Component: Template Keywords: needs-patch
Focuses: Cc:

Description

Follow this guidelines
http://24ways.org/2006/marking-up-a-tag-cloud

or others if you like, but having the font-size in the markup stinks :(

Change History (4)

comment:1 @DD326 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.7.1 to 2.9
  • Priority changed from high to normal
  • Version set to 2.7

So.. Going by those guidelines, Each item shouldn't have a size specified, Instead, It should be on a pre-determined ranking of 1-5 basically (or whatever scale chosen)

I do agree.. Having the size in the html stinks.. but it doesnt feel right to me to remove functionality like that.. Esp. when for backwards compat theres per-theme values to take into consideration.

Settings to 2.9 as theres no patch, Generally wouldn't make it into a .point release anyway.

comment:2 @hakre6 years ago

  • add new function wp_generate_tag_cloud_array() that takes care of data only
  • that data should handle the absolute weight (min-max) as well as relative (1-5)
  • use the new function on your own will
  • update wp_genereate_tag_cloud() to use the new function as well.

going that route will seperate the concerns and refactor wp_generate_tag_cloud() a bit.

comment:3 @Denis-de-Bernardy6 years ago

  • Milestone 2.9 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

yet another #5172 dup

comment:4 @hakre5 years ago

Related: #5031

Note: See TracTickets for help on using tickets.