WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8904 closed defect (bug) (fixed)

exclamation mark bang do not work in wordpress directory structure

Reported by: here Owned by:
Milestone: 2.8 Priority: low
Severity: minor Version: 2.7
Component: General Keywords: has-patch
Focuses: Cc:

Description (last modified by ryan)

Installed with exclamation mark or bang in directory structure, fails when saving new page:

http://localhost/code/!wp-test/<wp-files>

works fine with:

http://localhost/code/wp-test/<wp-files>

tested only with xampp 1.7 on win xp

Please confirm ;) --

Attachments (1)

8904.patch (539 bytes) - added by hakre 6 years ago.
Yes, ! (Exclamation mark) is a valid and safe char in an URI.

Download all attachments as: .zip

Change History (11)

comment:1 in reply to: ↑ description @here6 years ago

see also #3206

comment:2 @here6 years ago

  • Summary changed from exlamation mark bang do not work in wordpress directory structure to exclamation mark bang do not work in wordpress directory structure

comment:3 @simonwheatley6 years ago

Can you explain what you mean by "fails when saving new page", please?

comment:4 @ryan6 years ago

  • Component changed from General to Filesystem
  • Description modified (diff)
  • Owner anonymous deleted

comment:5 @Denis-de-Bernardy6 years ago

  • Keywords needs-patch added; exclamationmark bang directory exclamation mark removed
  • Milestone changed from 2.8 to 2.9

moving to 2.9 from lack of patch

comment:6 @hakre6 years ago

  • Keywords 2nd-opinion added

Changed Permalink Structure to

/bang!bang!/%year%/%monthnum%/%day%/%postname%/

which runs into errors when WP makes a redirect. seems to me that the redirect function is not properly working. again (?) another esoteric behavior.

In a second test I configured WordPress to be accessible under the following address:

http://example.com/bang!bang!beauty!/

with each redirect, the path is reduced to bangbangbeatuy, the exclamation marks get stripped out.

comment:7 @hakre6 years ago

  • Component changed from Filesystem to General
  • Owner set to anonymous

@hakre6 years ago

Yes, ! (Exclamation mark) is a valid and safe char in an URI.

comment:8 @hakre6 years ago

  • Keywords has-patch added; needs-patch 2nd-opinion removed

Someone has forgotten to add that char to the whitelist. Thanks for reporting.

comment:9 @markjaquith6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11147]) Exclamation mark is a valid and safe character in a URI. props hakre. fixes #8904

comment:10 @Denis-de-Bernardy6 years ago

  • Milestone changed from 2.9 to 2.8
Note: See TracTickets for help on using tickets.