WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

Last modified 15 years ago

#8947 closed defect (bug) (fixed)

optimization for install check

Reported by: denis-de-bernardy's profile Denis-de-Bernardy Owned by: joostdevalk's profile joostdevalk
Milestone: 2.8 Priority: low
Severity: minor Version: 2.7
Component: Optimization Keywords: has-patch dev-feedback commit
Focuses: Cc:

Description

currently, WP runs get_option(siteurl) as an install check, and proceeds to load all option if it isn't. would it not be more meaningful to load options first, and to check if get_option(siteurl) is set after doing so? or are there non-obvious reasons for doing things that way?

Attachments (1)

patch.diff​ (820 bytes) - added by joostdevalk 15 years ago.
Patch

Download all attachments as: .zip

Change History (8)

#1 @ryan
16 years ago

Sounds reasonable.

#2 @joostdevalk
16 years ago

  • Owner changed from anonymous to joostdevalk

Yes, way smarter, I'll write a patch.

#3 @joostdevalk
15 years ago

  • Keywords has-patch added; needs-patch removed

@joostdevalk
15 years ago

Patch

#4 @ShaneF
15 years ago

  • Keywords commit added

I tested the patch'; Doesn't kills the server. Code looks fine as well.

#5 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[10958]

#6 @DD32
15 years ago

Is there any reason why the $installed branches couldn't've been replaced simply with get_option()

..Or are there issues with Constant/filter overrides?

#7 @markjaquith
15 years ago

(In [10974]) Clean up is_blog_installed(), remove redundant or unnecessary code. see #8947

Note: See TracTickets for help on using tickets.