WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #8973, comment 19


Ignore:
Timestamp:
12/07/2015 01:56:57 AM (9 years ago)
Author:
dossy
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #8973, comment 19

    initial v1  
    1 I wrote up a test case to demonstrate the issue (a commenter's unapproved comments not being included in the count) and a patch to address it (see 8973-1.diff).  However, code that calls `get_page_of_comment()` will need to be updated to be aware of this in order for the user experience to Do The Right Thing, but I'm hoping this at least is a start in the right direction.
     1I wrote up a test case to demonstrate the issue (a commenter's unapproved comments not being included in the count) and a patch to address it (see [attachment:8973-1.diff]).  However, code that calls `get_page_of_comment()` will need to be updated to be aware of this in order for the user experience to Do The Right Thing, but I'm hoping this at least is a start in the right direction.