WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8992 closed enhancement (wontfix)

Plugin Update does not update plugin update count on success

Reported by: technosailor Owned by:
Milestone: Priority: low
Severity: minor Version: 2.7
Component: UI Keywords: needs-patch dev-feedback
Focuses: Cc:

Description

I don't know how to make that title make more sense. If you have, say, 3 plugin update notifications and you update one of them, upon re-activation the plugin update notification should update from 3 to 2. It doesn't. I'll try to patch this if I have time, but may not.

Attachments (2)

8992a.diff (1.3 KB) - added by technosailor 5 years ago.
8992.diff (3.0 KB) - added by DD32 5 years ago.

Download all attachments as: .zip

Change History (18)

technosailor5 years ago

comment:1 technosailor5 years ago

Here's initial API to move the plugin update notification to it's own function. Patch does not address ticket issue, but should make the rest easier without duplicating code. Adds function check_plugin_updates()

comment:2 DD325 years ago

Are we talking about the Bubble showing 3 updates WHILE one of the updates are being carried out?

If so, some jQuery could be used at the end of the update page to decrease it.. if need be.. afterall, on that pageload, there ARE 3 updates, once you go into any other page there'll be 2 updates..

comment:3 technosailor5 years ago

After the upgrade has happened, there should be 2 remaining upgrades. The bubble should reflect that change without a page reload as it does for the comments bubble when a comment has been moderated. jQuery could do it. With the above patch, the jQuery could invoke an AJAX call to that API function. Not sure which way is better but my javascript fu is shady and would take me 29.25 hours to complete a simple task - even with jQuery. ;)

DD325 years ago

comment:4 DD325 years ago

  • Keywords has-patch added

attachment 8992.diff added.

  • Bugger,Dirty patch, Ignore the Theme installer in wp-admin/menu.php
  • Moves function to a better location (It would've only worked in that location on the update page)
  • adds some jQuery to decrease/remove update bubble. Note: Will still be wrong when doing multiple updates at once.. but better than nothing. Ajax is virtually out of the question for that.. Way too much latency to even be worth it for such small data..

comment:6 Denis-de-Bernardy5 years ago

  • Milestone changed from 2.7.2 to 2.8

Why could it not be possible to make the actual upgrade occur before anything is output on the page? in particular the menu.

comment:7 DD325 years ago

Mainly because that increases the complexity of the code. No longer can things be echo'd straight away, they need to be stored in a var, kept around until the process finishes, and then be displayed in one large chunk.

As it is, The feedback rows are -supposed- to show up one by one.. but compression on many servers stops that.. But Not outputting anything can be disastrous, The user might not think anythings happening.. at least this way (for most people) it at least outputs the menu and header before any long processing happens, which makes people realise somethings happening.

comment:8 DD325 years ago

  • Milestone changed from 2.8 to Future Release

comment:9 Denis-de-Bernardy5 years ago

  • Component changed from General to Upgrade/Install
  • Owner anonymous deleted

comment:11 dd325 years ago

  • Keywords dev-feedback added

Some dev-feedback would be nice here, Should the update bubble be updated inline, or should users just put up with the bubble being wrong on that page load?

We could update the bubble to be {updates}-1 on the upgrade pageload.. but that doesnt really fit either IMO.

this patch is probably stale though.

comment:12 Denis-de-Bernardy5 years ago

  • Type changed from defect (bug) to enhancement

comment:13 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added; has-patch removed

stale patch

comment:14 dd325 years ago

  • Component changed from Upgrade/Install to UI
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Pretty sure this is a wontfix for now.

comment:15 strider725 years ago

Confused -- isn't "wontfix for now" the same as "future release"?

I mean, this *should* be fixed if it can be. Why not just leave it as Open with future release target?

comment:16 dd325 years ago

I mean, this *should* be fixed if it can be. Why not just leave it as Open with future release target?

Because whats the point in leaving something open thats just going to sit and rot for another few years until someone closes it then as exactly the same?

Note: See TracTickets for help on using tickets.