WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#8993 closed defect (bug) (wontfix)

options-permalink.php: drop trailing slash

Reported by: jidanni Owned by: ryan
Milestone: Priority: low
Severity: minor Version: 2.7
Component: Permalinks Keywords: has-patch tested
Focuses: Cc:

Description

Looking at the models offered on
wp-admin/options-permalink.php,
"month and name" is /%year%/%monthnum%/%postname%/ ,
But "numeric" is /archives/%post_id% .

Based on the responses in
http://news.gmane.org/find-root.php?message_id=87bptq89me.fsf@jidanni.org
I would say in those models:

1) Be consistent.

2) Drop the trailing slash.

Attachments (1)

add trailing slash to numeric example and auto-pop.diff (1.0 KB) - added by simonwheatley 5 years ago.
Patch to add trailing slash to the numeric permalink example and auto-pop code

Download all attachments as: .zip

Change History (11)

comment:1 filosofo5 years ago

Those responses say that it doesn't matter whether one uses the trailing slash, so it's not clear how you arrive at 2).

"Be consistent" with what? The permalink menu shows several different, common options, each of which is valid. Each when employed will be used consistently across the site. The menu examples demonstrate in a concise way the freedom of permalink construction.

comment:2 in reply to: ↑ description Elpie5 years ago

Replying to jidanni:

Based on the responses in
http://news.gmane.org/find-root.php?message_id=87bptq89me.fsf@jidanni.org
I would say in those models:

1) Be consistent.

2) Drop the trailing slash.

I think you may be misinterpreting those responses.
WP gives uers the choice of how to construct their permalinks - this is not a defect but is a feature of WP.

WP also applies the permalink structure consistently across the site so its only the site admin that can do anything to cause inconsistency in the links used on the site.

This is something that should not be changed because doing so would create major issues for existing WP users.

comment:3 Viper007Bond5 years ago

This ticket makes no sense.

Recommend closing as invalid.

comment:4 jidanni5 years ago

  • Cc jidanni@… added

simonwheatley5 years ago

Patch to add trailing slash to the numeric permalink example and auto-pop code

comment:5 simonwheatley5 years ago

  • Keywords has-patch added

I can see your point of view, Viper. This is a very minor improvement: added trailing slash to numeric permalink example and to the autopop code. Really only added a patch because it validated the time I spent working out the issue. :)

Verified permalinks still work (MAMP setup).

comment:6 follow-up: filosofo5 years ago

But adding a trailing slash to the end of the numeric permalink example is not an improvement. The point is to illustrate that a trailing slash is optional.

comment:7 in reply to: ↑ 6 simonwheatley5 years ago

Replying to filosofo:

But adding a trailing slash to the end of the numeric permalink example is not an improvement. The point is to illustrate that a trailing slash is optional.

I see. IMHO that's pretty subtle, do we expect (or need?) most users to pick up on that subtlety; perhaps it would be better to say "The trailing slash is optional." (As I said before though, this is pretty minor.)

comment:8 Denis-de-Bernardy5 years ago

  • Keywords tested added

comment:9 Denis-de-Bernardy5 years ago

  • Component changed from General to Permalinks
  • Owner changed from anonymous to ryan

comment:10 Denis-de-Bernardy5 years ago

  • Milestone 2.8 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Adding to the general trend of opinions, I personally see things such as:

/nodes/%post_id%

... on Drupal sites or WP sites that imitate its structure, and it's seldom followed by a trailing slash.

Closing as wontfix as a result.

Note: See TracTickets for help on using tickets.