Make WordPress Core

Opened 15 years ago

Last modified 3 years ago

#8994 new feature request

Incorporate MediaRSS Plugin into core

Reported by: technosailor's profile technosailor Owned by: technosailor's profile technosailor
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Feeds Keywords: has-patch dev-feedback
Focuses: Cc:

Description

Per conversation on the hackers list, this ticket is a working area for incorporation of the MediaRSS plugin (http://wordpress.org/extend/plugins/mrss) into core for WP 2.8.

Attachments (4)

8994_mrss.diff (6.3 KB) - added by hailin 15 years ago.
mrss feed
8994-2.diff (4.5 KB) - added by technosailor 14 years ago.
Use post_thumbnail features
8994.3.diff (4.4 KB) - added by stevenkword 7 years ago.
Refreshed
8994.diff (3.6 KB) - added by obenland 3 years ago.

Download all attachments as: .zip

Change History (30)

#1 @technosailor
15 years ago

  • Type changed from defect (bug) to task (blessed)

#2 @ryan
15 years ago

Is anyone in particular working on this?

#3 @hailin
15 years ago

I am interested in this, unless Andy wants to take over (since he wrote the mrss plugin), I will work on this.

#4 @ryan
15 years ago

  • Component changed from General to Feeds

@hailin
15 years ago

mrss feed

#5 @hailin
15 years ago

The implementation uses media_rss filter to add media rss feeds to rss2 feed.
It improves the current mrss plugin and uses filter instead of adding action to rss2_item.

In case the installation already has the current media rss plugin installed,
it needs to comment out add_action('rss2_ns', 'mrss_ns'); in mrss_init() in the plugin because that tries to add xmlns:media="http://search.yahoo.com/mrss/" to the name space, and will confuse feed reader if it's added twice.

#6 @ryan
15 years ago

  • Milestone changed from 2.8 to Future Release

That preg_match_all on post_content will likely bust backtrack limits.

#7 @technosailor
14 years ago

We could refactor this patch for 3.1 to use the_post_image() for mrss instead of preg_match_all. Thoughts?

@technosailor
14 years ago

Use post_thumbnail features

#8 @technosailor
14 years ago

Refreshed patch to use post thumbnail features. However, not tested. Would prefer to have blessing before going too much deeper.

#9 @nacin
13 years ago

  • Type changed from task (blessed) to feature request

#11 @prionkor
11 years ago

I was wondering if we could focus on this..

#12 @stevenkword
9 years ago

  • Focuses template added
  • Keywords 2nd-opinion dev-feedback added

I'd like to bring this one back up for discussion. Do we think this falls in the 80%? I am voting towards core adoption, but I'd like to get a group read on it before working towards further integration.

Last edited 9 years ago by stevenkword (previous) (diff)

#13 @swissspidy
8 years ago

#36272 was marked as a duplicate.

#14 @stevenkword
7 years ago

  • Keywords has-patch needs-refresh added

#15 follow-up: @swissspidy
7 years ago

Is MediaRSS still supported by major feed readers?

Would some people be surprised when their feed readers suddenly display their content differently?

#16 @lukecavanagh
7 years ago

@swissspidy

Seems MediaRSS is supported in Flipboard. https://about.flipboard.com/rss-spec/

@stevenkword
7 years ago

Refreshed

#17 @stevenkword
7 years ago

  • Keywords dev-feedback needs-refresh removed

#18 in reply to: ↑ 15 @stevenkword
7 years ago

Replying to swissspidy:

Is MediaRSS still supported by major feed readers?

Would some people be surprised when their feed readers suddenly display their content differently?

It is in the RSS2.0 spec, so I think we should support it. Aggregators shouldn't have any problems with it since we are only adding new tags. I'm decently sure MediaRSS was/is being used on a number of VIP sites, many of which are big media companies.

My $0.02 for any readers that don't parse it -- is it because 27% of the web doesn't provide the tag? Chicken/egg. It's in the spec, so I think we should emit them (or at least only the featured thumbnail which didn't exist until after MediaRss was written).

#19 @stevenkword
7 years ago

Looking at the patch I refreshed in comparison the original MediaRSS plugin. I think we should consider providing only the featured image. http://www.rssboard.org/media-rss#media-thumbnails

Last edited 7 years ago by stevenkword (previous) (diff)

#20 @swissspidy
7 years ago

See also this plugin I help maintain: https://wordpress.org/plugins/wp-feed-post-thumbnail/. Install stats aren't massive, but some people seem to use it. Perhaps it's helpful for creating a refreshed patch.

#21 @ocean90
6 years ago

#44049 was marked as a duplicate.

#22 @rijo
6 years ago

Newsstand was integrated now on Google News and Newsstand Producer is using RSS Feeds. A new reason to have feature images on the feeds :)

#23 @swissspidy
5 years ago

#46247 was marked as a duplicate.

#24 @swissspidy
5 years ago

  • Focuses template removed
  • Keywords needs-refresh needs-unit-tests added; 2nd-opinion removed

Looks like Google Newsstand indeed leverages and recommends MediaRSS (see https://support.google.com/news/producer/answer/6170026?hl=en), so that's definitely a prominent use case.

#25 @desrosj
4 years ago

Looks like this one still needs a refresh and unit tests. Is anyone able to work on that?

@obenland
3 years ago

#26 @obenland
3 years ago

  • Keywords dev-feedback added; needs-refresh needs-unit-tests removed

I added [8994.diff] as a first pass at a simplified solution based on @swissspidy's wp-feed-post-thumbnail suggestion. Maybe we could get this kicked off again?

/cc @stevenkword

Note: See TracTickets for help on using tickets.