Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#9038 closed defect (bug) (fixed)

"User Updated" text sticks after first successful update in admin page

Reported by: redsweater Owned by:
Milestone: 2.9 Priority: normal
Severity: minor Version: 2.7
Component: UI Keywords: has-patch
Focuses: Cc:


If you make a single successful change in the user profile editor in wp-admin, it tacks a "updated=true" parameter onto the GET URL, which sticks even as you continue to make possibly ineffective changes.

  1. Go to a user's edit page in wp-admin.
  2. Make a successful change such as changing a first name.
  3. Observe the "User updated." div near the top.
  4. Make an unsuccessful change such as a failed password change by entering different values in each field.

Result: the "User updated" div continues to appear in spite of the errors.

Whenever a submission causes zero changes to occur on the user's profile, any existing "User updated" div should be hidden.

(This is in trunk r10492.)

Attachments (2)

9038.diff (589 bytes) - added by dd32 6 years ago.
9038.2.diff (674 bytes) - added by dd32 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @Denis-de-Bernardy
7 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.8 to Future Release
  • Severity changed from normal to minor

this is an edge case, so punting. it would need to be checked/done in other admin screens as well.

#2 @Denis-de-Bernardy
6 years ago

  • Component changed from Administration to UI
  • Milestone changed from Future Release to 2.9

6 years ago

#3 @dd32
6 years ago

  • Keywords hsa-patch added; needs-patch removed

attachment 9038.diff added

  • That change passes a clean url to the post, so teh updated arg doesnt follow through.

Tested on

  • Own profile page
  • Another users edit page

#4 @dd32
6 years ago

  • Keywords has-patch added; hsa-patch removed

6 years ago

#5 @dd32
6 years ago

attachment 9038.2.diff added

  • Better patch using admin_url() instead

#6 @azaozz
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11830]) Remove old query args when updating user profile, props dd32, fixes #9038

Note: See TracTickets for help on using tickets.