Make WordPress Core

Opened 18 years ago

Closed 18 years ago

#9041 closed defect (bug) (fixed)

Infinite loop in livejournal API importer

Reported by: tellyworth Owned by: beaulebens
Priority: normal Milestone: 2.8
Component: General Version:
Severity: major Keywords:
Cc: Focuses:

Description

The new LiveJournal API importer #8999 gets stuck in an infinite loop when importing from a journal that has 0 comments.

The fault seems to lie with the $maxid > $highest_id logic in download_comments(). The first of those ("loop over the metadata request until we have it all") loops infinitely because $highest_id is never incremented.

Change History (2)

#1 @beaulebens
18 years ago

  • Owner changed from anonymous to beaulebens

Once we've sorted out the discussion going on over at #8999, I'll get a patch on here to handle this.

#2 @beaulebens
18 years ago

  • Resolution → fixed
  • Status new → closed

Fixed in r10538, but please confirm (lots of other changes in that revision as well).

Note: See TracTickets for help on using tickets.