WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9041 closed defect (bug) (fixed)

Infinite loop in livejournal API importer

Reported by: tellyworth Owned by: beaulebens
Milestone: 2.8 Priority: normal
Severity: major Version:
Component: General Keywords:
Focuses: Cc:

Description

The new LiveJournal API importer #8999 gets stuck in an infinite loop when importing from a journal that has 0 comments.

The fault seems to lie with the $maxid > $highest_id logic in download_comments(). The first of those ("loop over the metadata request until we have it all") loops infinitely because $highest_id is never incremented.

Change History (2)

comment:1 beaulebens5 years ago

  • Owner changed from anonymous to beaulebens

Once we've sorted out the discussion going on over at #8999, I'll get a patch on here to handle this.

comment:2 beaulebens5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r10538, but please confirm (lots of other changes in that revision as well).

Note: See TracTickets for help on using tickets.