WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#9058 closed defect (bug) (fixed)

Unescaped single quote like character within a string

Reported by: phsab's profile phsab Owned by: rmccue's profile rmccue
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

This was first reported to the WP MU dev team (#886), but donncha suggested to submit this to the WP dev team. So here it is....

While translating WP MU poedit stumbled over an unescaped single quote-like character within a string. It can be found at line 3429 in wp-admin/includes/template.php

<snip>...a module you’ll notice...</snip>

It may remain unnoticed, but that will depend on your language-setting.

Solution is to change it into:

<snip>...a module you\'ll notice...</snip>

Attachments (1)

9058.diff​ (1.3 KB) - added by rmccue 14 years ago.
Change raw smart quote to the corresponding (named) HTML entity

Download all attachments as: .zip

Change History (4)

#1 @rmccue
14 years ago

  • Component changed from General to i18n
  • Owner changed from anonymous to rmccue
  • Status changed from new to assigned

To be specific, this is a "smart quote" character. Should this be changed to a single quote, escaped, or should we be using the HTML entity for it ( &rsquo; )?

@rmccue
14 years ago

Change raw smart quote to the corresponding (named) HTML entity

#2 @rmccue
14 years ago

  • Keywords has-patch added; Unescaped single quote removed

#3 @westi
14 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10657]) Use the html entity for the smart quote. Fixes #9058 props rmccue.

Note: See TracTickets for help on using tickets.