Can not store 0 (zero) in meta_value using update_usermeta() in user.php

[stevejohnson]

The following lines in wp-includes/user.php evaluate $meta_value passed to update_usermeta() (current line #s from trunk):

397 	    if (empty($meta_value)) {
398 	        return delete_usermeta($user_id, $meta_key);
399 	    }

A numerical or string zero evals as empty, resulting in the inability to store zero as a meta_value.

A better test for truly empty might be:

397 	    if ($meta_value == '')) {
398 	        return delete_usermeta($user_id, $meta_key);
399 	    }

[stevejohnson]

I've been told that since this code section has been the same for over 2 years, it's probably best to leave it alone as changing it might break something that relies on this behavior.

[DD32]

Another thing: Everything is stored as a string (except arrays and objects), So passing (int)1 in, would result in (string)1 out, (bool)true results in (string)1 coming out.

I've found (This was with options, but the same holds for meta's) that wraping everything in an array is best array( (int)1 ); results in array( (int)1 ); coming out.

[jacobsantos]

Wish for the best of luck on creating a patch for this.

[stevejohnson]

Is it worth creating a patch for? If this is the way it's supposed to act, the ticket should be closed, yes?

[jacobsantos]

Replying to stevejohnson:

Is it worth creating a patch for? If this is the way it's supposed to act, the ticket should be closed, yes?

I do not feel that is for me to decide. If you wish to close it, then please do so.

[stevejohnson]

That was more of an "I'm new here, what should I do?" question.

Closed.

[jacobsantos]

PS: please remember to reset the milestone as well.

[jfarthing84]

I believe this should be re-opened because, although the original poster's method as storing the value as an array may work, it creates unnecessary storage amounts storing a serialized array for one single '0'.

[jfarthing84]

wp-includes/user.php

[scribu]

Related: #10837.

[Denis-de-Bernardy]

Related: #11380

[nacin]

The _usermeta API is now deprecated in favor of _user_meta, which uses our generic _metadata functions.

Thus, closing as wontfix for _usermeta. And we're now standardized across all meta APIs.