WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#9078 closed enhancement (fixed)

Inclusion of SSL Blacklisting in HTTP Transport Tests

Reported by: sivel Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: HTTP API Keywords: has-patch tested commit
Focuses: Cc:

Description

We are currently doing ssl blacklisting for certain transports by tacking on some logic to the if statements in the transport selection.

I'd like to add the ssl blacklisting to the test functions an update it a bit.

Since we are blacklisting transports that cannot do ssl verification, we should allow these transports to accept ssl if https_ssl_verify or https_local_ssl_verify are set to false by filters or if the call is made using 'sslverify' => 'false'

fsockopen can still not handle invalid ssl certs so it is ssl blacklisted no matter what.

Attachments (5)

9078.diff (7.2 KB) - added by sivel 7 years ago.
9078.2.diff (7.2 KB) - added by sivel 7 years ago.
9078.3.diff (6.1 KB) - added by sivel 7 years ago.
9078.4.diff (5.0 KB) - added by sivel 7 years ago.
list_transports.php (1.8 KB) - added by sivel 7 years ago.
Updated List Transports plugin

Download all attachments as: .zip

Change History (11)

@sivel7 years ago

comment:1 @sivel7 years ago

I'm also going to roll the use_*_transport filters into the tests as well.

One benefit of moving everything into the tests is that we will have to pass the $args array to the test. This will enable us in the long run to build out more extensive tests.

@sivel7 years ago

comment:2 @sivel7 years ago

If anyone would like to help in testing these changes it would be greatly appreciated. Report back here any issues you may run into.

@sivel7 years ago

@sivel7 years ago

comment:3 @sivel7 years ago

  • Cc matt@… added
  • Keywords tested commit added; needs-testing removed

Updates against recent updates on http.php

@sivel7 years ago

Updated List Transports plugin

comment:4 @sivel7 years ago

I updated the list transports plugin written by Ryan to show both POST and GET transports for both HTTP and HTTPS requests.

comment:5 @sivel7 years ago

  • Component changed from General to HTTP
  • Owner anonymous deleted

comment:6 @westi7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10642]) Refactor the ssl blacklisting support info the individual test functions. Fixes #9078 props sivel.

Note: See TracTickets for help on using tickets.