Upload Media: "Title" should not be overly sanitized

[mdawaffe]

When I upload an image called "Me and My Dread God of Rocking Chairs.JPG", it gets stored on my webserver as "me-and-my-dread-god-of-rocking-chairs.jpg". This is the correct behavior.

However, the post_title of the attachment is also sent through sanitize_with_dashes(), which is unnecessary.

Expected:
post_title = "Me and My Dread God of Rocking Chairs"

[Denis-de-Bernardy]

I'm pretty certain there's a dup of this in trac.

[hakre]

title should be the name (related to the filename of the upload) and not the newfilename (The one in fs then)

[hakre]

Check against Trunk: Still defect in trunk (/wp-admin/media-new.php)

Found the cause. See patch.

[Denis-de-Bernardy]

My Test.jpg gets a title of My Test.jp with the current patch

[hakre]

Fixed Patch

[Denis-de-Bernardy]

Doing my best to break it... :-)

Try:

My friend's \ / "funky" Test.jpg

[Denis-de-Bernardy]

(that's a valid file name on a Mac, dunno about Windows)

see also #9416

[hakre]

Yeah, you are pushing forward :D. Tested that/similar on sidux, you raised my interest. But that does not break the patch but the $_FILES array. That can not handle \ in filenames at least here on an apache running on win32. You can see that in the filename as well. So nothing to fix about that. And no way to retrieve that data whatsoever.

[hakre]

A trim does not hurt.

[Denis-de-Bernardy]

On a Mac, it returns "funky" Test.jpg as a file name. And My Friend's Test.jpg returns My Friend's Test.jpg.

But agreed, / and \ aren't supported by all platforms, so fixed as far as I'm concerned.

[Denis-de-Bernardy]

My Friend's Test.jpg returns My Friend's Test, even.

[ryan]

(In [11198]) Don't over sanitize uploaded file titles. Props hakre. fixes #9081