WordPress.org

Make WordPress Core

Changes between Initial Version and Version 7 of Ticket #9103


Ignore:
Timestamp:
02/27/09 17:32:51 (6 years ago)
Author:
westi
Comment:

Replying to jidanni:

I believe I'm trying to say: instead of your diff's

$title = sprintf(__('Search Results %s %s'), $t_sep, wp_specialchars($search));

You should do

$title = sprintf(__('%s %s Search Results'), wp_specialchars($search), $t_sep,);

As Google and Wikipedia do. Else you will have munched 75% of each tab with "Search Results". Better still would be

$title = sprintf(__('%s %s Search'), wp_specialchars($search), $t_sep,);

Mine are for a totally "leftist" solution. It seems your original should also be retained, to provide for an additional totally "rightest" choice.

Nope the diffs are correct.

WordPress is by default leftist.

If you want rightist you call wp_title in your theme with the third argument as 'right' and it flips them all round for you.

This is exactly how the default and classic themes do it.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9103

    • Property Status changed from new to assigned
    • Property Cc westi added
    • Property Component changed from Themes to Template
    • Property Owner set to westi
    • Property Milestone changed from to 2.8
    • Property Keywords has-patch needs-testing added
  • Ticket #9103 – Description

    initial v7  
    1  
    21WordPress (or at least its default theme) should consider putting the 
    32search string into the XHTML <title> of the search results page.