WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9111 closed defect (bug) (fixed)

Use short versions of ngettext functions

Reported by: nbachiyski Owned by: nbachiyski
Milestone: 2.8 Priority: normal
Severity: minor Version: 2.7
Component: I18N Keywords: has-patch tested
Focuses: Cc:

Description

Use _n instead of _ngettext and _n_noop instead of __ngettext_noop.

Attachments (2)

deprecate-longer-ngettext-functions.diff (3.2 KB) - added by nbachiyski 6 years ago.
shorter-ngettext-calls.diff (43.5 KB) - added by nbachiyski 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 @nbachiyski6 years ago

A patch to mark the longer alternatives as deprecated. They still work correctly.

comment:2 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10584]) Switch to pomo lib. Support gettext contexts. Deprecate long form functions. Props nbachiyski. fixes #9112 #9111

comment:3 @nbachiyski6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Here is an updated version of the patch, which replaces all __ngettext versions with _n. The previous didn't apply cleanly.

comment:4 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:5 @ryan6 years ago

(In [10606]) Use _n(). Props nbachiyski. fixes #9111

Note: See TracTickets for help on using tickets.