WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9139 closed defect (bug) (fixed)

Upgrade notice doesn't disappear after manual upgrade

Reported by: mastermind Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: Upgrade/Install Keywords: has-patch tested commit
Focuses: Cc:

Description

Before the automatic upgrade feature, it was possible to upgrade WordPress by three simple steps:

  • Delete all WP directories/files except wp-content and wp-config.php,
  • Upload all the new directories/files except wp-content and wp-config-sample.php,
  • Go to /wp-admin/upgrade.php.

With the new upgrading system, there is the problem that WordPress doesn't seem to recognize the new version: After a manual upgrade, It keeps on printing "WordPress [latest version] is available! Please update now". This is annoying, of course.

I hope you understand that there are scenarios which make it necessary to upgrade WordPress with other methods than the auto-upgrader.

Solution: The function to print the upgrading message should have a look into /wp-includes/version.php before and respect the value of $wp_version.

Attachments (1)

9139.diff (372 bytes) - added by Denis-de-Bernardy 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 mastermind5 years ago

Sorry for the stupid title of this ticket. It should better be something as "Upgrade notice doesn't disappear after manual upgrade". Unfortunately, I cannot edit the ticket.

comment:2 westi5 years ago

  • Cc westi added
  • Component changed from General to Upgrade
  • Owner anonymous deleted
  • Summary changed from Cannot upgrade manually anymore to Upgrade notice doesn't disappear after manual upgrade

This is because the message from the API is cached.

We need to ensure that cache is invalidated properly for a manual upgrade.

comment:3 westi5 years ago

  • Version set to 2.7

comment:4 DD325 years ago

just an extra version_compare() in the nag notice to clear the cache would probably suffice? would fix a lot of the "upgrade now!!" messages people complain about..

Denis-de-Bernardy5 years ago

comment:5 Denis-de-Bernardy5 years ago

  • Keywords has-patch tested dev-feedback added

probably the best we can do without going through complicated file date analysis...

comment:6 Denis-de-Bernardy5 years ago

there is a dup of this bug with a separate patch

comment:7 Denis-de-Bernardy5 years ago

  • Keywords commit added; dev-feedback removed

err, nm. the dup is related to something else.

comment:8 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11189]) Clear upgrade nag when doing manual upgrade. Props Denis-de-Bernardy. fixes #9139

Note: See TracTickets for help on using tickets.