Upgrade notice doesn't disappear after manual upgrade

[mastermind]

Before the automatic upgrade feature, it was possible to upgrade WordPress by three simple steps:

• Delete all WP directories/files except wp-content and wp-config.php,
  
• Upload all the new directories/files except wp-content and wp-config-sample.php,
  
• Go to /wp-admin/upgrade.php.

With the new upgrading system, there is the problem that WordPress doesn't seem to recognize the new version: After a manual upgrade, It keeps on printing "WordPress [latest version] is available! Please update now". This is annoying, of course.

I hope you understand that there are scenarios which make it necessary to upgrade WordPress with other methods than the auto-upgrader.

Solution: The function to print the upgrading message should have a look into /wp-includes/version.php before and respect the value of $wp_version.

[mastermind]

Sorry for the stupid title of this ticket. It should better be something as "Upgrade notice doesn't disappear after manual upgrade". Unfortunately, I cannot edit the ticket.

[westi]

This is because the message from the API is cached.

We need to ensure that cache is invalidated properly for a manual upgrade.

[DD32]

just an extra version_compare() in the nag notice to clear the cache would probably suffice? would fix a lot of the "upgrade now!!" messages people complain about..

[Denis-de-Bernardy]

probably the best we can do without going through complicated file date analysis...

[Denis-de-Bernardy]

there is a dup of this bug with a separate patch

[Denis-de-Bernardy]

err, nm. the dup is related to something else.

[ryan]

(In [11189]) Clear upgrade nag when doing manual upgrade. Props Denis-de-Bernardy. fixes #9139