WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 8 months ago

#9170 closed enhancement (wontfix)

"jQuerify" adding a new user...

Reported by: aaron_guitar Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Users Keywords:
Focuses: Cc:

Description

After adding a new user it's confusing that only that user is displayed in the table. It always takes me a couple seconds before I realize that it's just showing the new user. It seems it would be more efficient to show all of the users and just have the new row highlighted with jQuery.

(I can code this if needed.)

Attachments (1)

users.diff (2.6 KB) - added by aaron_guitar 5 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 FFEMTcJ5 years ago

  • Milestone changed from 2.7.2 to 2.8

Would be great if you can code it.

comment:2 FFEMTcJ5 years ago

  • Milestone changed from 2.8 to Future Release

comment:3 Denis-de-Bernardy5 years ago

  • Component changed from General to Users
  • Keywords needs-patch added
  • Owner anonymous deleted
  • Summary changed from Adding new user... to "Ajaxify" adding a new user...

maybe it could be done using ajax

comment:4 aaron_guitar5 years ago

I guess it's too late to submit a patch for this for 2.8?

comment:5 Denis-de-Bernardy5 years ago

  • Summary changed from "Ajaxify" adding a new user... to "jQuerify" adding a new user...

Writing this on the top of my head, but I vaguely recall seeing the behavior on other forums. (Add category?) So, in 2.8, I can picture the core devs rejecting it due to the introduction of inconsistencies in the interface.

On thing that's sure, though, is that an enhancement with no patch will never get considered in any version.

comment:6 aaron_guitar5 years ago

  • Cc aaron_guitar added

The way it's setup currently is inconsistent. I'm not really sure if completely Ajaxify-ing it would be the best solution. I was just thinking that it would be helpful if it highlighted the new user row after it was added. This would at least be more useful than the current setup. Thoughts anyone?

comment:7 Denis-de-Bernardy5 years ago

  • Keywords 2nd-opinion added

my fear, personally, would be that if you've thousands of users in there for any reason, a newly registered user definitely won't show.

then again, it could be argued that since the admin just created him, bringing him back to the all users list makes more sense. (and I'd +1 to that.) After all, he just created the user...

the same also applies to tags, cats, etc.

comment:8 follow-up: aaron_guitar5 years ago

Regarding your first comment, the scripting would have to figure out which page the new user would be displayed on and show that page.

All I know is the current way has no advantages over any other method =)

comment:9 in reply to: ↑ 8 Denis-de-Bernardy5 years ago

  • Keywords dev-feedback added

Replying to aaron_guitar:

Regarding your first comment, the scripting would have to figure out which page the new user would be displayed on and show that page.

All I know is the current way has no advantages over any other method =)

agreed. basically, we'd want to either identify on which page we are if it *has* to be visible on the screen. else we just dump the search query and return to the first page of results. either way make sense imo, as the current behavior is just misleading.

maybe a dev will stop by and suggest.

comment:10 aaron_guitar5 years ago

Agreed. I'll work on getting a patch up here soon.

aaron_guitar5 years ago

comment:11 aaron_guitar5 years ago

Has anybody had a chance to look at this?

comment:12 azaozz5 years ago

Don't think you need the js at all. To highlight the new user just set the style in user_row($user_object, $style, $role); when listing users.

Not sure if that's the proper behaviour in the first place. Perhaps after adding new user show a link to the profile in the "New user created" notice at the top. Jumping to some page in the user listing can be confusing too.

comment:13 aaron_guitar5 years ago

I don't really care much either way, it should be changed though.

comment:14 Denis-de-Bernardy5 years ago

  • Keywords 2nd-opinion dev-feedback removed

comment:15 Denis-de-Bernardy5 years ago

  • Milestone changed from Future Release to 2.9

comment:16 Denis-de-Bernardy5 years ago

  • Milestone changed from 2.9 to Future Release

comment:17 in reply to: ↑ description solarissmoke3 years ago

  • Keywords close added; needs-patch removed

Replying to aaron_guitar:

After adding a new user it's confusing that only that user is displayed in the table. It always takes me a couple seconds before I realize that it's just showing the new user.

In trunk, you get sent to the main user list after adding a new user, with a message saying "new user created".

comment:18 ocean908 months ago

  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The code has changed in the meantime. You will get the message "New user created. Edit user" and the list includes all users. No need to highlight a row.

Note: See TracTickets for help on using tickets.