add_magic_quotes now double-escaping post content when saving

[filosofo]

[10597] introduced the use of mysql_real_escape_string() in wpdb's escape() method.

However, when you save a post the content gets double-escaped, which means that line breaks are turned into \r\n and then \\r\\n.

The first escape is in wp-settings.php where applies add_magic_quotes() to $_POST.

The second is in wp_update_post() which applies it to the post content (wp_update_post() is called by edit_post()).

Then wp_update_post() calls wp_insert_post(), which calls stripslashes_deep(), so we end up with rn.

[mrmist]

Confirmed against multiple installations.

[ryan]

(In [10604]) Use mysql_real_escape_string() only in prepare(), insert(), and update(). escape() uses addslashes only. Add array support to escape(). see #9189

[hakre]

Related:

• #1394 - add_slashes() does not escape all database input correctly
• #11819 - Use mysql_real_escape_string instead of addslashes