Context Navigation

← Previous Ticket
Next Ticket →

#9193 closed defect (bug) (fixed)

get_terms() in wp_tag_cloud() didn't return a int

Reported by:	alexrabe	Owned by:	ryan
Priority:	low	Milestone:	2.8
Component:	Taxonomy	Version:	2.7
Severity:	normal	Keywords:	has-patch taxonomy get_term_link wp_tag_cloud
Cc:		Focuses:

Description

I took me a while, and I hope my analyse is correct. I try to use wp_tag_cloud() for my own taxonomy, but I'm not able to get a vaild term link. In get_term_link() i found that it look for a int|string|object. The term->id must be a int, but get_terms() in wp_tag_cloud() return a string array, so it's not possible to get the correct link.

Attched patch change the check from is_int -> is_numeric

Attachments (2)

taxonomy.patch (434 bytes ) - added by alexrabe 17 years ago.: is_numeric instead is_int
term_as_integer.9193.diff (531 bytes ) - added by filosofo 17 years ago.

Download all attachments as: .zip

Change History (6)

@alexrabe
17 years ago

Attachment taxonomy.patch added

is_numeric instead is_int

@filosofo
17 years ago

Attachment term_as_integer.9193.diff added

#1 @filosofo
17 years ago

I think the problem with checking is_numeric is that you're going to include searches for terms that might be numeric.

Better to address the problem at the source and pass an integer to get_term_link, when that's what you want. My patch should do that; does it solve your problem?

#2 @filosofo
17 years ago

Keywords has-patch taxonomy get_term_link wp_tag_cloud added

#3 @alexrabe
17 years ago

Of course this is another way and it will work for me as well

#4 @ryan
17 years ago

Resolution → fixed
Status new → closed

(In [10613]) Force term ID to be an int. Props filosofo. fixes #9193

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#9193 closed defect (bug) (fixed)

get_terms() in wp_tag_cloud() didn't return a int

Description

Attachments (2)

Change History (6)

@alexrabe 17 years ago

@filosofo 17 years ago

#1 @filosofo 17 years ago

#2 @filosofo 17 years ago

#3 @alexrabe 17 years ago

#4 @ryan 17 years ago