get_terms() in wp_tag_cloud() didn't return a int

[alexrabe]

I took me a while, and I hope my analyse is correct. I try to use wp_tag_cloud() for my own taxonomy, but I'm not able to get a vaild term link. In get_term_link() i found that it look for a int|string|object. The term->id must be a int, but get_terms() in wp_tag_cloud() return a string array, so it's not possible to get the correct link.

Attched patch change the check from is_int -> is_numeric

[alexrabe]

is_numeric instead is_int

[filosofo]

I think the problem with checking is_numeric is that you're going to include searches for terms that might be numeric.

Better to address the problem at the source and pass an integer to get_term_link, when that's what you want. My patch should do that; does it solve your problem?

[alexrabe]

Of course this is another way and it will work for me as well

[ryan]

(In [10613]) Force term ID to be an int. Props filosofo. fixes #9193