Hyphen in Theme Directory Breaks Theme Preview

[chrisjean]

There is a bug in the regex expressions in the preview_theme() function. The hyphen is not escaped, so themes that have hyphens in the directory name cause the function to return rather than continue. Thus, when previewing a theme with a hypen in the directory, all that is rendered is a white page.

The attached diff corrects this issue when scrubbing both the template and the stylesheet.

[DD32]

See: #8548 (reopened defect (bug)): Theme preview fails when theme in subdirectory

(Might be best to close as duplicate and add patch over there?)

[FFEMTcJ]

Dup of #8548

[automattor]

(In [10677]) Escape hyphen in regex. Props chrisbliss18. fixes #8548 #9244 for 2.7

[filosofo]

This is probably overly punctilious, but the backslash is unnecessary and its intended purpose might seem unclear to people in the future. Patch attached.

[azaozz]

(In [10824]) Less confusing regex, props filosofo, fixes #9244

[chrisbliss18]

Just to play devil's advocate here, I'm not sure how putting the hyphen at the end again is less confusing. It simply adds the potential of reintroducing this bug if someone adds yet another character at the end of the character class.

[filosofo]

Replying to chrisbliss18:

Just to play devil's advocate here, I'm not sure how putting the hyphen at the end again is less confusing. It simply adds the potential of reintroducing this bug if someone adds yet another character at the end of the character class.

A mere backslash won't prevent all the potential damage to a regex done by someone who modifies it without understanding.

Moving the hyphen to the beginning or the end of the character class makes its purpose unambiguous to a knowledgeable person, and it eliminates an excess character.

And now I must return to trimming my lawn with a nail clipper.