WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#9247 closed defect (bug) (fixed)

Use WordPress HTTP class for SimplePie requests

Reported by: DD32 Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: General Keywords: has-patch needs-testing
Focuses: Cc:

Description

Whilst SimplePie's request class may work in most cases, There will be times when it wont. The HTTP class also has more functionality than the SimplePie class.

AFAIK, SimplePie will expand it in the future(rmccue) however, Its right now i'm concerned about.

The HTTP Class also allows people to disable transports which do not work for them, Or to set proxies/blacklistings, For that reason alone, SimplePie should utilise the HTTP Class.

Attached patch converts it, I've done small ammount of testing, There doesnt appear to be any problems, However, Testing will be needed to ensure its acting 100% like the SimplePie_File, Mainly with regards to headers.

Attachments (1)

9247.diff (3.8 KB) - added by DD32 11 years ago.

Download all attachments as: .zip

Change History (2)

@DD32
11 years ago

#1 @ryan
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10687]) Use WordPress HTTP class for SimplePie requests. Props DD32. fixes #9247

Note: See TracTickets for help on using tickets.