WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #9296, comment 18


Ignore:
Timestamp:
03/30/11 07:00:08 (3 years ago)
Author:
andrewryno
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9296, comment 18

    initial v1  
    1 Looking over my patch, I'm wondering if messages should be handled via add_settings_error() in options.php as well? The permalink messages depend on some variables, so if those messages are moved, those variables will either have to be moved or copied (since they are used elsewhere in options-permalink.php). Ryan said he would like to see those moved as well, but just to a different function, not options.php. 
     1Looking over my patch, I'm wondering if messages should be handled via add_settings_error() in options.php as well? The permalink messages depend on some variables, so if those messages are moved, those variables will either have to be moved or copied (since they are used elsewhere in options-permalink.php). Ryan said he would like to see the messages moved as well, but just to a different function, not options.php. 
    22 
    33Thoughts? I'd be willing to take this on to the best of my abilities, just want some direction on what might be the best route.