Plugin updater does not show plugin messages after bulk actions are applied.

[jwriteclub]

After applying a bulk delete action, the messages (such as update notices) below plugins are not displayed.

Attached are two images of a plugin update screen before and after a plugin was deleted with the "bulk delete". Note that the number next to plugins in the main menu has not changed, nor has the version number of the plugin in question.

Firefox 3.0.7 (Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7 (.NET CLR 3.5.30729))

Woirdpress 2.7.1 with MySQL 4.2 and PHP 5

[jwriteclub]

The plugin interface before the bulk action is applied

[jwriteclub]

The plugin interface after the bulk action is applied

[Denis-de-Bernardy]

merging into #7875

[DD32]

I'm going to leave this separate Denis, It sounds like the update is being deleted, and not checked before the page is displayed..

Its not really an issue with the upgrader process

[DD32]

Assigning to Self for testing, and to remind myself of this ticket

[Denis-de-Bernardy]

See also #8992

[hakre]

Replying to jwriteclub:

After applying a bulk delete action, the messages (such as update notices) below plugins are not displayed.

after applying a bulk action, there is no need to see update messages for certain plugins. this is a feature of the standard listing and not of the return-page after bulk things have been done.

[DD32]

Re-opening due to it being a bug due to bad timing of update checks.

The issue is this:

• Updates are available
• Init is fired, as well as load-plugins.php, this is the hook the update check runs on
• Bulk Action applied (Delete)
  • Deletion occurs
  • Deletion removes the update_plugins transient
• Page continues to load (Not redirect like most other actions)
• Plugins listing is shown
  • Plugin update row item is called, however transient is empty since an update check hasnt run since the transient was deleted after the bulk action was applied.

I dont think the transient needs to be deleted after a plugin deletion, So what if theres a old stale plugin in the transient for a few hours?(that is NOT going to be shown) Its not going to affect performance much..

Patch coming up in just a minute.

[DD32]

2.8 since release of 2.8 is so close.

[hakre]

class WP_Upgrader has that code as well.

[hakre]

managed transient

[hakre]

I extended the patch a bit to just reflect the deleted plugin(s). This might help with re-installations of plugins.

[DD32]

class WP_Upgrader has that code as well.

For a reason.

The workflow for a plugin upgrade is completely different, and the update cache needs to be invalidated upon a plugin upgrade to prevent showing the upgrade message again.

I thought about simply modifying the transient, but, That didnt seem like a useful thing..

..Actually, It just occured to me, Yes, A bad cache IS A bad thing, the update count bubble will not update correctly.

I'd change that code i deleted to this:

 if ( $current = get_transient('update_plugins') ) { 
    unset( $current->response[ $plugin_file ] );
    set_transient('update_plugins', $current);
 }

Seems like a better approach than your patch(Less code branches modified), but still achieves the same result.

[Denis-de-Bernardy]

based on DD32's suggestion

[Denis-de-Bernardy]

commit? wontfix?

[ryan]

(In [11207]) Fix display of plugin update messages after bulk ops. Props DD32. fixes #9303