Make WordPress Core

Opened 17 years ago

Closed 12 years ago

Last modified 12 years ago

#9306 closed enhancement (duplicate)

Additional smart quote suggestion

Reported by: cloak42 Owned by:
Priority: low Milestone:
Component: Formatting Version:
Severity: trivial Keywords: wptexturize
Cc: Focuses:

Description

If a user writes a post that contains a quotation inside parentheses, the open quote mark is not used. I suggest that when a quotation mark (double or single) is used after an open parenthesis, it should be a left-quote “ instead of a right quote ”. In order to be as complete as possible, it would probably be best to ensure that this is only done in the event that white space is used prior to the open parenthesis so as to prevent it printing the wrong one if, say, a sad-face smiley is used inside a quotation, like so:

She told me, "Aw, you make me a sad panda now. :("

If it's done so that it will only open the quote correctly after white space \s or a carriage return, I think that will cover the vast majority, if not all, of the situations where it would need to be used.

Change History (11)

#1 @FFEMTcJ
17 years ago

  • Milestone UnassignedFuture Release

#2 @Denis-de-Bernardy
17 years ago

  • Component GeneralFormatting
  • Owner anonymous removed

#3 @Denis-de-Bernardy
17 years ago

  • Keywords needs-patch added

#4 @Denis-de-Bernardy
17 years ago

  • Milestone Future Release2.9

#5 @janeforshort
17 years ago

  • Milestone 2.9Future Release

Punting due to feature freeze.

#6 @solarissmoke
16 years ago

  • Keywords close added; needs-patch smart quote replacement preg_replace removed

I got this to work just by adding a space after the last quotation mark - it then renders as a proper closing quote. IMO this is quite edge and messing with how brackets are handled could break other things.

#7 @westi
16 years ago

#4539 has a lot of changes to this code.

This should be reviewed when the changes there are reviewed and committed.

#8 @nacin
13 years ago

  • Keywords wptexturize added

#9 @miqrogroove
12 years ago

  • Resolutionworksforme
  • Status newclosed

Fixed in [11813]

I tested this post body:

("This is a test quote")

The output was

<p>(&#8220;This is a test quote&#8221;)</p>

This is the intended behavior since version 2.9.

#10 @SergeyBiryukov
12 years ago

  • Keywords close removed
  • Resolution worksformeduplicate

Duplicate of #1418.

#11 @SergeyBiryukov
12 years ago

  • Milestone Future Release
Note: See TracTickets for help on using tickets.