WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 20 months ago

Last modified 20 months ago

#9321 closed enhancement (fixed)

Dashboard page navigation does not gracefully degrade with CSS off

Reported by: jidanni Owned by:
Milestone: 3.5 Priority: lowest
Severity: trivial Version: 2.7.1
Component: Accessibility Keywords: ux-feedback
Focuses: Cc:

Description

Try the dashboard with a text browser (lynx, w3m) or with stylesheets
turned off, you will see that for dashboard page the navigation menu
must be scrolled over to get at the meat of each of the various dashboard pages clicked.

Contrast with MediaWiki pages, where the navigation is placed at bottom.

Attachments (1)

9321.patch (1.2 KB) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added
  • Milestone set to Future Release

comment:2 Denis-de-Bernardy5 years ago

Suggesting wontfix unless a patch comes up. Else, this ticket will rot for ages.

comment:3 johnbillion4 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

This is a super easy thing to fix (a 3 line patch), but the problem it introduces is we have to move the 'adminmenu' hook too. This means the hook moves all the way from the beginning of the page down to the end, and will probably break plugins.

Patch attached.

Opinions on whether this is workable or not would be appreciated.

johnbillion4 years ago

comment:4 nacin4 years ago

  • Component changed from Administration to Accessibility
  • Keywords ux-feedback added; dev-feedback removed
  • Milestone changed from Future Release to Unassigned

I'm not sure we can do this without breaking a lot. I know there has been some thought of a very accessible version of the WP admin being created, for screen readers etc. We're no-JS supportive, but not at all no-CSS supportive.

Marking for ux-feedback, let's see if Jane has any thoughts here. I imagine it'll be a wontfix.

comment:6 jane4 years ago

  • Milestone changed from Unassigned to Future Release

I actually would like the admin to look nice and be easy to use without CSS on, but it's too late for 3.0 a)in general, way past freeze, and b) because as Nacin says, it might break things. We should look at it in the next version. Not a top priority, but something that would be good to do if the patch tests out okay.

comment:7 lloydbudd4 years ago

  • Summary changed from Dashboad page navigation does not gracefully degrade with CSS off to Dashboard page navigation does not gracefully degrade with CSS off

comment:8 follow-up: johnbillion4 years ago

Westi grepped the plugin repo this morning and found that not one single plugin uses the 'adminmenu' hook. This means there is no issue with regard to this hook moving.

What else could potentially break in plugins if this patch was applied? JS? CSS?

comment:9 nacin4 years ago

  • Keywords 3.2-early added

I didn't even know there was an adminmenu hook.

A lot could break here for sure, so let's evaluate in 3.2 and see what we could do about it.

comment:10 johnbillion3 years ago

I wonder if there's still time to evaluate this in time for 3.2 as per http://make.wordpress.org/accessibility/?p=12.

We could introduce the change in trunk as a test run to see if any problems arise. As we've seen, the adminmenu hook is used by zero plugins, leaving custom JavaScript as the only real place this could cause breakage.

comment:11 johnbillion3 years ago

  • Keywords needs-refresh added; has-patch removed

comment:12 in reply to: ↑ 8 saracannon3 years ago

  • Cc sararcannon@… added

Replying to johnbillion:

Westi grepped the plugin repo this morning and found that not one single plugin uses the 'adminmenu' hook. This means there is no issue with regard to this hook moving.

What else could potentially break in plugins if this patch was applied? JS? CSS?

Just because plugins in the repo aren't using the hook doesn't mean that people aren't utilizing it internally for their own custom CMS's. We should be careful.

comment:13 grahamarmfield2 years ago

Would not an in-page or 'Skip' link at the top as I suggested in #21310 not help with this one?

comment:14 sabreuse20 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Skip links were added in [21435]. Closing as fixed based on that. If there are any new issues, let's move those to new tickets about the specific issues since the whole structure of the admin has changed since this ticket was originally raised.

comment:15 SergeyBiryukov20 months ago

  • Keywords 3.2-early needs-refresh removed
  • Milestone changed from Future Release to 3.5
Note: See TracTickets for help on using tickets.