E_NOTICE undefined offset in wp-includes/theme.php

[Mittineague]

With my Error Reporting plugin I get

E_NOTICE
Undefined offset: 1 at /home/mittineague/mittineague.com/blog/wp-includes/theme.php (212)
timed at 15-Mar-2009 01:53:41

eg. (several similar lines)

{{{if ( preg_match( '|Author URI:(.*)$|mi', $theme_data, $author_uri ) )

$author_uri = clean_url( trim( $author_uri[1]) );}}}

preg_match returns FALSE upon an error, or 0 or 1 $matches found. It is possible for no $matches to be found causing $matches[1] to be undefined using the conditional if ( preg_match() )

[DD32]

Changing the regex's to (.+) should fix this possibility?

[filosofo]

Replying to DD32:

Changing the regex's to (.+) should fix this possibility?

No, because if you had for example just "Theme URI:" the parentheses would capture nothing and put it in $theme_uri[1], avoiding the undefined notice. This happens when there's no Theme URI line whatsoever; the preg_match returns false, but later on the $theme_uri[1] is used.

[azaozz]

(In [10825]) Fix notice in wp-includes/theme.php, props filosofo, fixes #9336