WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9365 closed defect (bug) (fixed)

Plugin Installation Notice Fixes

Reported by: sivel Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: General Keywords: has-patch
Focuses: Cc:

Description

Notice: Trying to get property of non-object in /var/www/trunk/wp-admin/includes/plugin-install.php on line 421

Attachments (2)

9365.1.diff (939 bytes) - added by sivel 5 years ago.
9365.2.diff (1.9 KB) - added by sivel 5 years ago.

Download all attachments as: .zip

Change History (10)

sivel5 years ago

comment:1 sivel5 years ago

  • Cc matt@… added
  • Keywords has-patch added

comment:2 sivel5 years ago

  • Summary changed from plugin-install.php Notice Fix to Misc admin notice fixes

comment:3 sivel5 years ago

  • Summary changed from Misc admin notice fixes to plugin-install.php Notice Fix

comment:4 sivel5 years ago

  • Summary changed from plugin-install.php Notice Fix to Plugin Installation Notice Fixes

comment:5 sivel5 years ago

download_url and plugin_name are not in the $REQUEST var and do not appear to be needed.

sivel5 years ago

comment:6 westi5 years ago

(In [10820]) Fix notice in plugin installer. See #9365 props sivel

comment:7 westi5 years ago

Not sure about the other change.

It maybe that it should go or that the wrong vars are being used or that it is partly implemented code.

comment:8 DD325 years ago

  • Resolution set to fixed
  • Status changed from new to closed

All the items here have been fixed.

9365.2.diff points out very well that plugin/theme_name and download_url dont need to be passed in the URL's.. See upcoming patch on #7875 (which includes a few other items)

Note: See TracTickets for help on using tickets.