WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#9365 closed defect (bug) (fixed)

Plugin Installation Notice Fixes

Reported by: sivel Owned by:
Priority: normal Milestone: 2.8
Component: General Version: 2.8
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Notice: Trying to get property of non-object in /var/www/trunk/wp-admin/includes/plugin-install.php on line 421

Attachments (2)

9365.1.diff​ (939 bytes ) - added by sivel 17 years ago.
9365.2.diff​ (1.9 KB ) - added by sivel 17 years ago.

Download all attachments as: .zip

Change History (10)

@sivel
17 years ago

#1 @sivel
17 years ago

  • Cc matt@… added
  • Keywords has-patch added

#2 @sivel
17 years ago

  • Summary plugin-install.php Notice Fix → Misc admin notice fixes

#3 @sivel
17 years ago

  • Summary Misc admin notice fixes → plugin-install.php Notice Fix

#4 @sivel
17 years ago

  • Summary plugin-install.php Notice Fix → Plugin Installation Notice Fixes

#5 @sivel
17 years ago

download_url and plugin_name are not in the $REQUEST var and do not appear to be needed.

@sivel
17 years ago

#6 @westi
17 years ago

(In [10820]) Fix notice in plugin installer. See #9365 props sivel

#7 @westi
17 years ago

Not sure about the other change.

It maybe that it should go or that the wrong vars are being used or that it is partly implemented code.

#8 @DD32
17 years ago

  • Resolution → fixed
  • Status new → closed

All the items here have been fixed.

9365.2.diff points out very well that plugin/theme_name and download_url dont need to be passed in the URL's.. See upcoming patch on #7875 (which includes a few other items)

Note: See TracTickets for help on using tickets.