Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#9375 closed enhancement (fixed)

Use Jcrop for image header cropping

Reported by: joelpittet Owned by: ryan
Milestone: 2.8 Priority: low
Severity: minor Version: 2.8
Component: JavaScript Keywords: needs-patch
Focuses: Cc:



I was poking around in the wordpress svn trunk and saw that you were the last one to touch the scriptaculous directory. Then I did a bit of poking more and noticed you guys only used that framework for cropping, it seems. Here is a nice jQuery plugin for that. http://deepliquid.com/projects/Jcrop/demos.php?demo=handler

I would love to try to implement this if you think it's a good idea. Also, if that replaces the last scriptaculous dependancy would you consider removing that library or do you keep it for plugin's that might tie into it?

If keep it, would you like the latest bug fix release in a patch?

Attachments (1)

Jcrop.noconflict.diff (1.2 KB) - added by nbachiyski 9 years ago.

Download all attachments as: .zip

Change History (9)

#1 @westi
9 years ago

  • Keywords needs-patch added
  • Milestone changed from Unassigned to Future Release

It would be good to see a patch to do this conversion so that everything is jQuery based.

We would likely still keep scriptaculous around for plugins.

#2 @ryan
9 years ago

Indeed, a patch would be appreciated, especially since the current cropper seems to be broken in trunk.

#3 @ryan
9 years ago

(In [10846]) Use Jcrop for cropping. see #9375

#4 @ryan
9 years ago

  • Milestone changed from Future Release to 2.8

#5 @ryan
9 years ago

  • Summary changed from Cropper & Scriptaculous Library to Use Jcrop for image header cropping

#6 @hakre
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Eh, isn't this fixed now? I close it then, commit is in.

#7 @nbachiyski
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Jcrop doesn't work with the non-conflict version of jQuery -- it expects $ to be the jQuery class. Patch is attached. I sent it upstream, too.

#8 @ryan
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10863]) Make jCrop compatible with noConflict. Props nbachiyski. fixes #9375

Note: See TracTickets for help on using tickets.