Gallery column number inline CSS issue

[ECodeStudio]

Having more than one gallery on a single page causes the latest one in code to override the "number of columns" property of the above ones.
This issues is easily fixed by adding the gallery id attribute.

Here is a code snippet to go into wp-includes/media.php

$output = apply_filters('gallery_style', "
        <style type='text/css'>
            #gallery-{$id} .gallery {
                margin: auto;
            }
            #gallery-{$id} .gallery-item {

                float: left;
                margin-top: 10px;
                text-align: center;
                width: {$itemwidth}%;            }
            #gallery-{$id} .gallery-icon img {
                border: 1px solid #cfcfcf;
            }
            #gallery-{$id} .gallery-caption {
                margin-left: 0;
            }
        </style>
        <!-- see gallery_shortcode() in wp-includes/media.php -->
        <div class='gallery' id='gallery-{$id}'>");

[hakre]

ECodeStudio, do you know how you can create a patch file? I do one, so you can take a look.

[hakre]

Having an ID in there is nice to CSS but I do not understand your report fully.

[Denis-de-Bernardy]

patch isn't good. it also needs to modify the css.

@hakre: there is a dup or two of this bug somewhere. But basically, what happens is:

• create 3 posts, the first and last with galleries that have 3 columns, and the one in the middle with 2 columns.
• display the blog page

notice that they all have the same number of columns. the suggested change fixes this quite well. much better than what was suggested in the related tickets.

[hakre]

Denis-de-Bernardy: So what to suggest. Just close this ticket? (would be fine with that).

[Denis-de-Bernardy]

see also #7678 more essentially the same fix, using a class instead

[hakre]

I suggest to close #9400 (this) as a duplicate because the suggestion in #7678 (there) are better.

[Denis-de-Bernardy]

I'd agree if the patch on #7678 didn't contain a bug. $id != $post->ID in there. on the contrary, $id is that of an attachment.

Once that patch gets updated, +1.

[Denis-de-Bernardy]

(or this one)

[Denis-de-Bernardy]

See #7678, with a better patch.