WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9408 closed enhancement (fixed)

WAI-ARIA landmark roles in default theme to increase accessibility

Reported by: peterkz Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Themes Keywords: accessibility, has-patch, aria, wai, tested
Focuses: Cc:

Description

The WAI ARIA specification defines a set of specialised "landmark" roles. These roles provide a method to programmatically identify commonly found sections of web page content in a consistent way.

This allows assistive technologies to provide users with features which they can use to identify and navigate to sections of page content. For more information see Using WAI ARIA Landmark Roles by Steve Faulkner.

This patch adds basic ARIA landmark role information to the default theme.

Attachments (2)

default_theme_landmark_roles.diff (5.0 KB) - added by peterkz 6 years ago.
default_theme_landmark_roles_valid.diff (2.6 KB) - added by peterkz 6 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 @peterkz6 years ago

  • Cc peterkz added
  • Keywords has-patch added; patch removed

comment:2 follow-up: @DD326 years ago

  • Version set to 2.8

Since i assume this isnt yet a released standard, I guess it'll mean the theme will not pass validation? (Which is a meaningless mark i know, I'm just thinking of all the nazi's :))

comment:3 in reply to: ↑ 2 @peterkz6 years ago

Replying to DD32:

Since i assume this isnt yet a released standard, I guess it'll mean the theme will not pass validation? (Which is a meaningless mark i know, I'm just thinking of all the nazi's :))

Apparently the W3C are looking into modifying the W3C validator to include experimental support for WAI-ARIA. Currently other validators have included a custom DTD to enable validation (e.g. Markup validator S.A.C).

Personally, I take accessibility over validation any day:-)

comment:4 follow-up: @peterkz6 years ago

Added an optional version that makes use of the jQuery library included with Wordpress to set the landmark roles. This means that the HTML is still valid.

comment:5 @MarcoZ6 years ago

  • Cc marco.zehe@… added

comment:6 in reply to: ↑ 4 @MarcoZ6 years ago

Replying to peterkz:

Added an optional version that makes use of the jQuery library included with Wordpress to set the landmark roles. This means that the HTML is still valid.

I just tried this patch against SVN R10943, and it doesn't work. JAWS does not report the landmarks don't show up on either the front page or the single post views. The patch applied cleanly, so the approach to do it via jQuery doesn't seem to work right yet.

Peter, did JAWS show you the landmarks when you implemented this version of the patch?

comment:7 @MarcoZ6 years ago

  • Keywords tested added

I tested the hardcoded landmarks patch, and it works great. Since the theme already has the aria-required attribute hardcoded and thus doesn't pass validation anyway, and it was once said that accessibility enhancement should be favored over the validation, I recommend to take this patch.

comment:8 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10945]) Add WAI-ARIA landmark roles to default theme. Props peterkz. fixes #9408

comment:9 @ryan6 years ago

  • Milestone changed from Unassigned to 2.8
Note: See TracTickets for help on using tickets.