WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 4 months ago

#9427 closed defect (bug) (wontfix)

Output Broken: Invalid Output (Error) on Dashboard: autocomplete and (Warning but more serious) name/id conflict

Reported by: hakre Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Dashboard output (admin backend) has at least an error. patched it.

Attachments (1)

qcop-r00-admin-dashboard.patch (1.0 KB) - added by hakre 6 years ago.
dashboard errors

Download all attachments as: .zip

Change History (7)

@hakre6 years ago

dashboard errors

comment:1 follow-up: @azaozz6 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Perhaps the autocomplete="off" should go in the <form> element. It may not be accepted by the W3C but is the de-facto standard supported by almost all browsers.

Having name != id is not a violation of any standard.

comment:2 @Denis-de-Bernardy6 years ago

  • Milestone Unassigned deleted

comment:3 in reply to: ↑ 1 ; follow-up: @sampablokuper6 years ago

  • Cc sam.kuper@… added
  • Milestone set to 2.9
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Replying to azaozz:

Perhaps the autocomplete="off" should go in the <form> element. It may not be accepted by the W3C but is the de-facto standard supported by almost all browsers.

Leaving invalid (X)HTML in core WordPress code is unacceptable, IMO. It means that plugin and theme developers, among others, can no longer use the W3C validator to check that their plugin/theme/etc isn't producing invalid (X)HTML at a glance: they instead have to look or parse through the validation results to see if the reported issues are due to core WordPress files or not. What a pain. Consequently, I'm reopening this ticket.

By the way, in WordPress 2.8.6 the dashboard now additionally contains the following invalid markup:

<textarea class="comment" rows="3" cols="10">Hi, this is a comment.<br />To delete a comment, just log in and view the post&#039;s comments. There you will have the option to edit or delete them.</textarea>

That <br /> isn't permitted in <textarea>.

comment:4 in reply to: ↑ 3 ; follow-up: @azaozz6 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

comment:5 in reply to: ↑ 4 @sampablokuper6 years ago

Replying to azaozz:

Replying to sampablokuper:
It seems it's part of the things to come: http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-form-autocomplete

If/when WordPress starts using the HTML 5 doctype by default, then fine, use @autocomplete . In the meantime, it's invalid and needs patching.

Also, what about the <br /> I mentioned above?

comment:6 @DrewAPicture4 months ago

  • Milestone 2.9 deleted
Note: See TracTickets for help on using tickets.