WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9429 closed enhancement (fixed)

Output Broken: Theme Widgets Admin Output does not validate

Reported by: hakre Owned by:
Milestone: 2.8 Priority: lowest
Severity: trivial Version: 2.7
Component: Widgets Keywords: has-patch needs-testing
Focuses: Cc:

Description

The HTML Output of widgets.php in the backend does produce a lot of errors. This is mainly because, '%i%' has been choosen as placeholder. But '%' is not a valid char in HTML IDs.

Therefore the only thing to fix this is to change the placeholder to something HTML conform. For Example '.i.'. The attached patch does fix this (and #9428).

Attachments (1)

qcop-r00-admin-widget.patch (4.1 KB) - added by hakre 5 years ago.
patching %i% in widgets handling.

Download all attachments as: .zip

Change History (7)

hakre5 years ago

patching %i% in widgets handling.

comment:1 follow-up: hakre5 years ago

While testing, I run into problems adding new Widgets. Removing does work.

comment:2 in reply to: ↑ 1 hakre5 years ago

Replying to hakre:

While testing, I run into problems adding new Widgets. Removing does work.

my fault, this is related to #9444 which did not load in the .dev.js files. to test the patch, you must enable script debugging for the script-loader.php. To my knowledge this can only be done manually by modifying the script-loader.php file.

comment:3 hakre5 years ago

test done: no problems to add widgets (on wp-admin/widgets.php) with this patch.

comment:4 ryan5 years ago

  • Component changed from General to Widgets
  • Owner anonymous deleted

comment:5 Denis-de-Bernardy5 years ago

  • Keywords needs-testing added
  • Milestone changed from Unassigned to 2.8
  • Priority changed from normal to lowest
  • Severity changed from normal to trivial
  • Type changed from defect (bug) to enhancement
  • Version set to 2.7

better check if this works well with #9511

comment:6 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

We use a different placeholder now, which should address this.

Note: See TracTickets for help on using tickets.