Output Broken: Ticket for collecting patches to proplery encode script and other href attribute values

[hakre]

The output does not validate in certain points because ampersands (&) are not properly used within urls (should be & not a sole &).

this ticket contains patches to fix various of such issues.

[hakre]

amp; was missing on post edit page

[hakre]

codepress validation patch

[hakre]

plugin editor multiple ampersands and a missing ID (accidently taken over from the theme editor, had to be named plugin)

[hakre]

Finished with checking the Admin. All pages dones. This should fix all amp; Issues in the Admin but not one with generating CSS for the default theme header image. But that is not solveable w/o changing the overall parameter design.

[ryan]

See #9402

[hakre]

when #9402 is fixed with a changeset, these patches here need to be updated.

[Denis-de-Bernardy]

patch is b0rke (or possibly it no longer applies)

[ryan]

I think everything went in on other tickets.

[hakre]

_wp_dashboard_recent_comments_row() in dashboard.php is using get_comment_link() but does not escape it properly for XHTML usage. I created a helper function to do the job (so that a single point needs to be fixed in case of a bad implementation). Patch follows.

[hakre]

clean_url()

[hakre]

forget the note about the helper function, clean_url() does it.

[hakre]

missing cdata added.

[hakre]

clean_url() does not &ersand, esc_attr() should be used.

[Denis-de-Bernardy]

mmm, you may want to double check that. when the output is meant to be displayed (the default), it should convert un-converted & to &. westi raised a separate bug the other day, however, related to double-escaping no longer occurring or something.

[hakre]

Put both new patches into one.

[hakre]

double checked it now, clean_url() does &038; (same as &), so it is OK to use it. esc_attr() does &, so it is OK for that to use it as well. clean_url() is my preference here.

i put both changes into one patchfile as well.

[azaozz]

(In [11375]) HTML validity fixes, props hakre, fixes #9432

[hakre]

missing fixes went into a new ticket, see #10257