Some Hook names are localized and therefore rendered useless

[hakre]

Some Hook Names are localized. For Example the string "settings" will be translated to "einstellungen". Something goes horribly wrong because of that, Hook Names are not consistent when WordPress is beding localized (which is normal).

The HookName I stumbeled over:
"einstellungen_page_breadcrumb-navxt"

This seems to be related with registering Submenu Pages.

[hakre]

I could dig in a bit more. This falls on my feet again. This makes the development of a Plugin Page complicated since you can not gain knowlege about the name of the hook in development.

this is where the localized name is coming from (global array):
$admin_page_hooks[$parent]

this is in get_plugin_page_hookname() in wp-admin/includes/plugin.php

this array is filed off from the menu array which is defined in wp-admin/menu.php

the solution is quite easy. there only needs a little fix in assigning the name there. instead of taking a localized string, I suggest to take the name of the actual php file, the extension removed.

[hakre]

a simple change removes the localization.

[hakre]

Hookname before patch: "einstellungen_page_breadcrumb-navxt"
Hookname after patch: "options-general_page_breadcrumb-navxt"

that is a german localized wordpress, this is a admin_page_hook in the breadcrumb plugin.

[hakre]

Hookname before patch: "einstellungen_page_breadcrumb-navxt"

Hookname after patch: "options-general_page_breadcrumb-navxt"

that is a german localized wordpress, this is a admin_page_hook in the breadcrumb plugin.

[ryan]

I seem to recall some plugins breaking last time we tried to fix this, but I am not certain. I tested this with my usual menu testing plugins and all was well, so let's try this out for 2.8 and be wary of reports of plugins breaking.

[ryan]

(In [11017]) Use unlocalized hook name. Props hakre. fixes #9438

[Denis-de-Bernardy]

thank you so much... this was *sooooo* annoying, because it rendered those functions essentially useless. :-)

[Denis-de-Bernardy]

original patch breaks a few plugins. fix attached

[ryan]

(In [11032]) Hook name back-compat from Denis-de-Bernardy. fixes #9438

[hakre]

thanks.

[coffee2code]

The backwards compatibility fixes added in r11032 is missing the mapping of : 'themes' => 'appearance'

Patch 9438.2.diff is attached.

[coffee2code]

Adds missing back-compat mapping

[Denis-de-Bernardy]

woops! :P

[ryan]

(In [11113]) More hook back-compat. Props coffee2code. fixes #9438