WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9464 closed enhancement (fixed)

Update PclZip to 2.7

Reported by: simek Owned by:
Milestone: 2.8 Priority: normal
Severity: minor Version: 2.8
Component: Administration Keywords: has-patch needs-testing
Focuses: Cc:

Description

I prepare updated file + spacebars are replaced with tabs. After this file is about 20kB smaller.

Tested and works for me, but additional tests will be a good idea.

Attachments (2)

pclzip.update.patch (71.0 KB) - added by simek 5 years ago.
Patch widthout Spaces to Tabs conversion, because with conversion file has 430kB and attachment limit is to low
class-pclzip.php (243.1 KB) - added by simek 5 years ago.
Spaces into Tabs version of file [about 23kB less]

Download all attachments as: .zip

Change History (10)

simek5 years ago

Patch widthout Spaces to Tabs conversion, because with conversion file has 430kB and attachment limit is to low

comment:1 DD325 years ago

  • Component changed from Upload to Administration
  • Milestone changed from Unassigned to 2.8
  • Owner set to anonymous

I see no problems with it, But it'll need testing for sure.

I say put it into trunk and see if any problems arrise, The 64-bit OS bug fix which we originally had has been merged in upstream, that was the only real change that was ever made from memory.

comment:2 azaozz5 years ago

Simek, to work around the attachment size limit you can zip the large changeset and attach it as a binary file or attach the actual class-pclzip.php that includes your changes.

simek5 years ago

Spaces into Tabs version of file [about 23kB less]

comment:3 simek5 years ago

I know it azaozz, but I forget that I can upload pure PHP file or ZIPped patch. Thank You for your advice.

comment:4 simek5 years ago

  • Type changed from defect (bug) to enhancement

comment:5 Denis-de-Bernardy5 years ago

@azaozz: any reason for this to not get committed on the spot?

comment:6 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11025]) Update pclzip to 2.7. Props simek. fixes #9464

comment:8 ryan5 years ago

(In [11038]) Use dist pczlip. see #9615 #9464

Note: See TracTickets for help on using tickets.