WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9465 closed defect (bug) (fixed)

Comments CSS-Classnames aren't properly assigned in get_comment_class()

Reported by: hakre Owned by:
Milestone: 2.7.2 Priority: normal
Severity: normal Version:
Component: Template Keywords: has-patch
Focuses: Cc:

Description

the function get_comment_class() (/wp-includes/comment-template.php) has a little flaw in adding class names to the class array. this can lead to problems if filter want to check for a specific classname in the classes-array.

it can be easily fixed. this will prevent plugin authors and theme designers to create complicated hotfix code.

the supplied patch fixes this behaviour for the byuser classname being in one with the comment-author-... .

Attachments (1)

9465-classnames-fixed.patch (733 bytes) - added by hakre 5 years ago.
byuser now in it's own array entry. fixes problems with getting un-normalized data.

Download all attachments as: .zip

Change History (5)

hakre5 years ago

byuser now in it's own array entry. fixes problems with getting un-normalized data.

comment:1 westi5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10875]) Move byuser to a seperate array entry to ease filtering by plugins. Fixes #9465 for trunk props hakre.

comment:2 westi5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 2.7 branch

comment:3 automattor5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10876]) Move byuser to a seperate array entry to ease filtering by plugins. Fixes #9465 for 2.7 branch props hakre.

Note: See TracTickets for help on using tickets.