Update Diff Engine [patch included]

[simek]

I prepared patch which update Diff engine files to latest versions.

I've tested those changed files on my test blog and everything was ok.

[hakre]

this patch will help wordpress become more PHP5 compatible. that means: better workin in current environments.

let me smile: all php4 users should drop dead :D

[Denis-de-Bernardy]

Replying to hakre:

this patch will help wordpress become more PHP5 compatible. that means: better workin in current environments.

let me smile: all php4 users should drop dead :D

the patch also means php4 users will be using more memory, no?

[hakre]

Well php 4 users will use more memory but PHP 5 users will use less memory.

+1 A step in the right direction.

[Denis-de-Bernardy]

mm, php5 users would use the same memory. they'd be carrying an object reference no matter what.

[hakre]

Replying to Denis-de-Bernardy:

mm, php5 users would use the same memory. they'd be carrying an object reference no matter what.

That's what many PHP users believe but it is not the case. It uses more memory if you pass objects with &, it is not the same as without.

[hakre]

Need to correct my last statement. I made a little Test with a current PHP 5.2.x version and it is not the case any longer. Memory Usage remains the same.

[Denis-de-Bernardy]

Right. And that would be valid in php5.0 as well. Per the php docs, objects are always a pointer (in other words, a php reference) in php5.

[Denis-de-Bernardy]

this can wait. it improves nothing, nor does it fix anything.

[westi]

Moving out of 2.9 for now as this is an enhancement not a bug.

[Simek]

I've added new patch which update Text Diff to most recent release.

[Simek]

Most recent version according to ​http://cvs.horde.org/framework/Text_Diff/

[Simek]

Maybe 3.0 release is the good time to update it?

[nacin]

The &'s need to go back in. Those are for PHP4 compatibility.

I wouldn't remove the ticket reference to #7391.

Un-patching those things should make this patch much smaller and would look much better for 3.0. The only changes I see are:

• New option to diff at the character-level.
• Detects line breaks, CL vs RF vs CRLF.
• Two new functions to count number of added and deleted lines.

[automattor]

(In [13211]) Update Text_Diff. Props simek. Fixes #9467