add_rewrite_endpoint() doesn't work

[Denis-de-Bernardy]

While editing a plugin, I've noticed that this fails miserably:

add_rewrite_endpoint('print', EP_PERMALINK);

While this succeeds:

global $wp_rewrite;
$wp_rewrite->add_endpoint('print', EP_PERMALINK);
$wp_rewrite->flush_rules();

Shouldn't it flush the rules automatically?

[filosofo]

Replying to Denis-de-Bernardy:

Shouldn't it flush the rules automatically?

No. Adding an endpoint and generating the rewrite rules are two separate actions. When you add an endpoint, you're adding an endpoint to the pool of potential endpoints, which will be used the next time the rewrite rules are generated. So whereas one regenerates the rewrite rules only infrequently (for example, when a plugin is activated), the endpoint needs to be added to the pool of potential endpoints on every load of WP, so that it will be available to use in the case that something else flushes and regenerates the rules.

[Denis-de-Bernardy]

Ok... so it's like, the flush should occur on activate and deactivate then.

It should probably be clarified in the docs, then.

[Denis-de-Bernardy]

Marking as needs testing, as I've resolved to not using this at all on my end.

[ryan]

(In [11102]) Clarify add endpoint phpdoc. Props Denis-de-Bernardy. fixes #9476