WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#9484 closed defect (bug) (fixed)

A raw col element is gummed up instead of left alone

Reported by: CharlieHamu Owned by: CharlieHamu
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7.1
Component: Formatting Keywords: has-patch tested
Focuses: Cc:

Description

I used the HTML col element in order to right-align a table column.

I fixed this by adding col to the list of HTML elements in formatting.php.

Here's my code:
<table class="contacts"><col /><col /><col align="right"/><tr style="color:orange">

Here's the post that provoked the problem:
http://danforthgreens.ca/toronto-danforth-2008-results/

My patch is attached.

Attachments (2)

add-col-to-list-of-html-elements-in-formatting-php.diff (937 bytes) - added by CharlieHamu 6 years ago.
Patch to formatting.php
9484.diff (1.5 KB) - added by Denis-de-Bernardy 6 years ago.
fixed patch

Download all attachments as: .zip

Change History (13)

@CharlieHamu6 years ago

Patch to formatting.php

comment:1 @CharlieHamu6 years ago

  • Owner changed from anonymous to CharlieHamu

Sorry. There's a line missing between the first ("I used") and the second ("I fixed"):

My col tags got eaten up.

The truth is that I'm not clear exactly what went wrong at what stage of the process.

It was several years ago that I found and fixed this problem on my own copy of WordPress.

But my prediction is that if you try to use a <col align="right"/> in an unpatched WordPRess, you will meet with sadness.

And the line that I patched is a long list of all HTML tags. Except col. So it makes sense to add col there.

comment:2 @CharlieHamu6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 @CharlieHamu6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 @CharlieHamu6 years ago

Sorry, this is my first bug report and first patch submission.

So I'm not clear on the protocol about when it gets marked as fixed.

I'll go read the instructions.

comment:5 @tomontoast6 years ago

  • Keywords has-patch added; html removed
  • Milestone changed from Unassigned to 2.7.2
  • Version set to 2.7.1

comment:6 @Denis-de-Bernardy6 years ago

  • Keywords tested added; formatting col removed

comment:7 follow-up: @DD326 years ago

@Denis-de-Bernardy: Next time you might want to close the latter ticket off if the older one has the exact same patch :P

Also, I'd appreciate it if you'd investigate your Diff making program to root diff's at WordPress's Root(ie. wp-admin/file.php instead of ../../denis/what/wp-admin/file.php) , It messes up some patching programs since they dont understand the extra paths, and get confused when they cant find an exact patch match..

@Denis-de-Bernardy6 years ago

fixed patch

comment:8 in reply to: ↑ 7 @Denis-de-Bernardy6 years ago

Replying to DD32:

@Denis-de-Bernardy: Next time you might want to close the latter ticket off if the older one has the exact same patch :P

I hadn't even looked at the patch, to be honest. But yeah, you're right. :-)

Also, I'd appreciate it if you'd investigate your Diff making program to root diff's at WordPress's Root(ie. wp-admin/file.php instead of ../../denis/what/wp-admin/file.php) , It messes up some patching programs since they dont understand the extra paths, and get confused when they cant find an exact patch match..

My bad. I've two local copies of WP (one is Semiologic Pro and the other is a verbatim WP trunk), and I occasionally mix up between the two. I hadn't realized it added inappropriate path references. :P

patch is fixed

comment:9 @ryan6 years ago

  • Milestone changed from 2.7.2 to 2.8

comment:10 @ryan6 years ago

  • Component changed from General to Formatting

comment:11 @azaozz6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [11070]) Add <col> to list of block elements, props CharlieHamu and Denis-de-Bernardy, fixes #9484

Note: See TracTickets for help on using tickets.