Using "Cancel" link in widget admin causes that widget to lose all its options on save

[markjaquith]

Observed:

When in the Widgets admin, if you open a widget and then click the "Cancel" link, upon Saving, that widget will lose all its settings.

Expected:

Clicking "Cancel" should revert to the last saved state, resulting in no change when saved.

[Denis-de-Bernardy]

Just for reference, there are two or three other tickets related to the exact same thing. And I vaguely recall this was fixed in WP 2.5 (I had reported it then).

[DD32]

I vaguely recall this was fixed in WP 2.5 (I had reported it then).

This ones related to the new Widget class

[ryan]

The POST info for the widget is empty after Cancel is pressed. Edit -> Cancel -> Edit -> Done preserves the info. The new widgets are assuming that update() is always called with full info for $new_instance. We can do like the old widgets do and merge $new_instance over $old_instance. I'll hold off on that until after the UI update. Maybe we can fix Cancel.

[ryan]

I think the new UI will fix this. Will confirm once it lands.

[Denis-de-Bernardy]

See also: #9511

[azaozz]

Ryan is right, fixed in the new UI.