WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#9508 closed defect (bug) (fixed)

Theme Installer; Correct update check & silence WP Version warning if no data available.

Reported by: DD32 Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

As the title suggests.. Patch does 2 things, Fixes an error upon attempted theme install when there's a theme update available, And removes the "theme untested with your WP version" if the theme hasnt specified which version its compatible/requires.

Attachments (4)

9508.diff (1.8 KB) - added by DD32 6 years ago.
9508.2.diff (5.4 KB) - added by DD32 6 years ago.
9508.3.diff (5.0 KB) - added by DD32 6 years ago.
9508.patch (1.1 KB) - added by Viper007Bond 6 years ago.

Download all attachments as: .zip

Change History (16)

@DD326 years ago

comment:1 @DD326 years ago

Patch also fixes a notice error in the theme tag search defaults..

@DD326 years ago

comment:2 @DD326 years ago

attachment 9508.2.diff added

  • Includes changes from original patch
    • Silence Tested/Require warnings unless value is supplied
    • Fixes an unset variable notice (due to missing global)
    • Fixes a fatal error in the installer in the event that a theme upgrade is available
  • Fixes a notice-level error on the theme search listing in the event that there is not $theme_num % 3 == 0 themes.
  • Uses the correct theme name for non-current themes which have an update (This needs to be backported to 2.7.x, the changes are those to the wp-admin/theme.php file)

comment:3 @DD326 years ago

Also, Cant make a patch for it right now, But the nonce on this line: http://core.trac.wordpress.org/browser/trunk/wp-admin/update.php#L85 needs to be changed, from "upgrade-plugin_" to "upgrade-theme_" to match http://core.trac.wordpress.org/browser/trunk/wp-admin/update.php#L159

comment:4 @ryan6 years ago

patch is choking on the patch.

comment:5 @DD326 years ago

patch is choking on the patch.

Patch refresh coming up.

@DD326 years ago

comment:6 @DD326 years ago

try that one

comment:7 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10923]) Theme insall cleanups. Props DD32. fixes #9508

comment:8 @Viper007Bond6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

A few more notices DD32 missed.

@Viper007Bond6 years ago

comment:9 @Viper007Bond6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

[Tue 02:25:18] <DD32> Viper007Bond: ah... I didnt miss those notices.... I removed that code entirely... :P
[Tue 02:25:25] <DD32> (upcoming patch)

comment:10 @Viper007Bond6 years ago

[Tue 02:25:18] <DD32> Viper007Bond: ah... I didnt miss those notices.... I removed that code entirely... :P
[Tue 02:25:25] <DD32> (upcoming patch)

comment:11 @DD326 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Lets get Viper007Bond's patch commited anyway.

comment:12 @DD326 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.