Theme Installer; Correct update check & silence WP Version warning if no data available.

[DD32]

As the title suggests.. Patch does 2 things, Fixes an error upon attempted theme install when there's a theme update available, And removes the "theme untested with your WP version" if the theme hasnt specified which version its compatible/requires.

[DD32]

Patch also fixes a notice error in the theme tag search defaults..

[DD32]

attachment 9508.2.diff added

• Includes changes from original patch
  • Silence Tested/Require warnings unless value is supplied
  • Fixes an unset variable notice (due to missing global)
  • Fixes a fatal error in the installer in the event that a theme upgrade is available
• Fixes a notice-level error on the theme search listing in the event that there is not $theme_num % 3 == 0 themes.

• Uses the correct theme name for non-current themes which have an update (This needs to be backported to 2.7.x, the changes are those to the wp-admin/theme.php file)

[DD32]

Also, Cant make a patch for it right now, But the nonce on this line: ​http://core.trac.wordpress.org/browser/trunk/wp-admin/update.php#L85 needs to be changed, from "upgrade-plugin_" to "upgrade-theme_" to match ​http://core.trac.wordpress.org/browser/trunk/wp-admin/update.php#L159

[ryan]

patch is choking on the patch.

[DD32]

patch is choking on the patch.

Patch refresh coming up.

[DD32]

try that one

[ryan]

(In [10923]) Theme insall cleanups. Props DD32. fixes #9508

[Viper007Bond]

A few more notices DD32 missed.

[Viper007Bond]

[Tue 02:25:18] <DD32> Viper007Bond: ah... I didnt miss those notices.... I removed that code entirely... :P
[Tue 02:25:25] <DD32> (upcoming patch)

[Viper007Bond]

[Tue 02:25:18] <DD32> Viper007Bond: ah... I didnt miss those notices.... I removed that code entirely... :P
[Tue 02:25:25] <DD32> (upcoming patch)

[DD32]

Lets get Viper007Bond's patch commited anyway.