Opened 16 years ago
Last modified 5 years ago
#9510 new enhancement
Multiple feed fixes and enhancements
Reported by: | peaceablewhale | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | major | Version: | 2.7.1 |
Component: | Feeds | Keywords: | needs-refresh dev-feedback |
Focuses: | Cc: |
Description
Currently, the feed always returns the same subtitle, self link, alternate link and replies link no matter what the page type is. I think they should be different for each page type.
Attachments (7)
Change History (38)
@
16 years ago
atom:id should be changed as well. This patch replaces the feed-atom.php part of the previous patch.
#3
@
16 years ago
Thanks simek for the patch. I have uploaded a new patch replacing the feed-atom.php part.
This is the first time for me to generate a patch file. Please let me know if I have done anything wrong. Thanks.
#5
@
16 years ago
- Keywords needs-testing added
- Milestone changed from Unassigned to 2.8
Could this be added in WordPress 2.8?
#10
@
15 years ago
- Milestone changed from 2.8 to Future Release
- Type changed from defect (bug) to enhancement
Postponing from 2.8.
#14
@
15 years ago
- Keywords needs-review added; needs-testing removed
- Summary changed from Show different subtitle, self link, alternate link and replies link in Atom feed based on the page type to Show different subtitle, self link, alternate link and replies link in feeds based on the page type
#17
@
15 years ago
Patch updated to fix a problem that the required <description> element is sometimes not displayed under RSS 2 channel.
#20
@
15 years ago
- Summary changed from Show different subtitle, self link, alternate link and replies link in feeds based on the page type to Multiple feed fixes and enhancements
#21
@
15 years ago
Added the changes proposed in #10509, also made Atom support sy:updatePeriod and sy:updateFrequency.
#22
follow-up:
↓ 23
@
15 years ago
- Cc beau@… added
Not to be too picky, but it'd be nice if this was closer to the WordPress Coding Standard. Specifically, reversing most comparisons, spacing things out a bit to make them easier to read and avoiding quote-escaping by going between single and double quotes where appropriate.
That being said, after a very quick visual skim over the code it looks like it adds a lot more flexibility and robustness to the feed system of WP, so I'm all for it (haven't tested to see if the patch applies cleanly or does as advertised). Looks very thorough.
feed_link() and feed_entry_link() looked identical (except for the filter they run), perhaps they can just be combined into a more generic feed_link() function, with a parameter indicating what filter to run over the resulting code, or just have it run at the point that calls them?
You're using get_lastpostmodified() to get a value for feed_updated(), but it seems like that value would not necessarily be accurate for anything except the full-site feed. If there's an easy way to get that date from the first matching item in the feed, that seems like that would consistently give you the correct value for that specific feed.
#23
in reply to:
↑ 22
@
15 years ago
@beaulebens:
Thanks for your comment. I will upload a patch that conforms to the coding standard later.
The refreshed patch is expected to combine feed_link() and feed_entry_link() into generic_feed_link(), with a parameter indicating which filter to be used.
I know that get_lastpostmodified() is problem... but I am not able to fix that until #4575 is fixed...
#24
@
15 years ago
After a second thought, I think that adding $is_entry to feed_link() is better. A refreshed patch has been uploaded, and it is now closer to the WordPress Coding Standard.
#27
@
15 years ago
- Keywords needs-testing added; needs-review removed
Marking this report "needs-testing" in order to gain attention in the upcoming bug hunt.
#29
@
10 years ago
- Keywords needs-refresh dev-feedback added; has-patch needs-testing removed
Someone from core want to re-review whether WordPress core should do the proposed idea? On the basis, the idea seems good, and provides alot of additional flexibility. Lastest patch (patch 4) would need to be refreshed)
Initial attempt to add those features to feed-atom.php