Multiple feed fixes and enhancements

[peaceablewhale]

Currently, the feed always returns the same subtitle, self link, alternate link and replies link no matter what the page type is. I think they should be different for each page type.

[peaceablewhale]

Initial attempt to add those features to feed-atom.php

[peaceablewhale]

Initial attempt to add new functions to link-template.php

[peaceablewhale]

get_day_feed_link and get_day_comments_feed_link functions are to be added...

[simek]

Changes into attached PHP files in one patch file - diff preview

[peaceablewhale]

atom:id should be changed as well. This patch replaces the feed-atom.php part of the previous patch.

[peaceablewhale]

Thanks simek for the patch. I have uploaded a new patch replacing the feed-atom.php part.

This is the first time for me to generate a patch file. Please let me know if I have done anything wrong. Thanks.

[peaceablewhale]

New patch, replaces all old patches.

[peaceablewhale]

The v2 patch has included the changes proposed in #9515, the patch will have to be updated when #9515 is settled.

In addition, since I have made many modifications to the files, I would like to get some comments from the core developers.

[peaceablewhale]

Could this be added in WordPress 2.8?

[Denis-de-Bernardy]

patch applies cleanly

[peaceablewhale]

This report will be updated after #9515 is fixed.

[Denis-de-Bernardy]

patch is b0rke

[peaceablewhale]

Patch updated.

[peaceablewhale]

Version 3 of the patch, changes from #9515 adopted, with minor corrections

[ryan]

Postponing from 2.8.

[Denis-de-Bernardy]

patch still applies clean

[peaceablewhale]

Patch will be updated after #4967 is fixed.

[peaceablewhale]

A new patch has been uploaded, with the changes proposed in #4967 excluded. The patch also fixes #9992, #9831 and some formatting issues in feeds.

[peaceablewhale]

The updated version 4 patch fixes #4523 as well.

[peaceablewhale]

Correction: It's #4253, not #4523

[peaceablewhale]

Patch updated to fix a problem that the required <description> element is sometimes not displayed under RSS 2 channel.

[peaceablewhale]

Attempt to fix #8828 as well.

[peaceablewhale]

Added the change proposed in #10016

[peaceablewhale]

Added the changes proposed in #10509, also made Atom support sy:updatePeriod and sy:updateFrequency.

[beaulebens]

Not to be too picky, but it'd be nice if this was closer to the ​WordPress Coding Standard. Specifically, reversing most comparisons, spacing things out a bit to make them easier to read and avoiding quote-escaping by going between single and double quotes where appropriate.

That being said, after a very quick visual skim over the code it looks like it adds a lot more flexibility and robustness to the feed system of WP, so I'm all for it (haven't tested to see if the patch applies cleanly or does as advertised). Looks very thorough.

feed_link() and feed_entry_link() looked identical (except for the filter they run), perhaps they can just be combined into a more generic feed_link() function, with a parameter indicating what filter to run over the resulting code, or just have it run at the point that calls them?

You're using get_lastpostmodified() to get a value for feed_updated(), but it seems like that value would not necessarily be accurate for anything except the full-site feed. If there's an easy way to get that date from the first matching item in the feed, that seems like that would consistently give you the correct value for that specific feed.

[peaceablewhale]

@beaulebens:

Thanks for your comment. I will upload a patch that conforms to the coding standard later.

The refreshed patch is expected to combine feed_link() and feed_entry_link() into generic_feed_link(), with a parameter indicating which filter to be used.

I know that get_lastpostmodified() is problem... but I am not able to fix that until #4575 is fixed...

[peaceablewhale]

After a second thought, I think that adding $is_entry to feed_link() is better. A refreshed patch has been uploaded, and it is now closer to the WordPress Coding Standard.

[peaceablewhale]

Updated the patch to resolve the conflict caused by [11864].

[peaceablewhale]

Updated the patch to resolve the conflict caused by [11980].

[peaceablewhale]

Marking this report "needs-testing" in order to gain attention in the upcoming bug hunt.

[chriscct7]

Someone from core want to re-review whether WordPress core should do the proposed idea? On the basis, the idea seems good, and provides alot of additional flexibility. Lastest patch (patch 4) would need to be refreshed)

[chriscct7]

Related: #4253

[callumbw95]

Hi All,

I have just come across this ticket now, and looks to be collection of atom feed related issues from 2009. However, this ticket bundles multiple distinct issues together, a practice no longer followed and discouraged as it makes tracking and resolving them difficult. Furthermore, in the 15+ years since this ticket was opened against WordPress 2.7, the core codebase has evolved dramatically.

At least one of the issues reported here was confirmed fixed in ticket #9515, and it is highly likely that other items have been resolved implicitly or have become obsolete due to other architectural changes. The patches attached are also over a decade old and no longer apply to the current codebase.

For these reasons, unfortunately this ticket is no longer actionable in its current form, and as of such I have added the close tag. If any of the specific issues originally discussed here are still present and relevant in a modern version of WordPress, I encourage you to open a new separate ticket for each one, with a refreshed description and a modern patch. However if you feel my decision here is wrong, please feel free to remove the close tag and continue the conversation further. 😃