WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9525 closed defect (bug) (fixed)

WP Filesystem changes

Reported by: DD32 Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Just a few changes/enhancements/bugfixes for the Filesystem Abstraction classes.

  • Bring the FTP Constants inline with find_folder() - Moves all the processing for the various folders to a single function, much easier to handle
  • Changes the folder locations from WP_Filesystem to -always- return a trailing slash, This is for maximum compatibility with all host setups, ie. abspath == ftp foot == /, In the current setup, it can end up using a path such as which causes some problems with some setups
  • Lots of formatting cleanups
  • Return a standardised chmod return values for all classes, May need further testing, But given each class was returning something different, and Core isnt using it, I'm pretty certain its a safe change
  • return false on attempting to delete a empty path - If a bug occurs, and something asks to delete "null" or "" then prevent it from deleting, some take this to mean delete "." or "/"
  • (FTP) Better support for listing for a single file in a directory (ie. /wordpress/.maintanence)

Attachments (1)

9525.diff (13.3 KB) - added by DD32 6 years ago.

Download all attachments as: .zip

Change History (4)

@DD326 years ago

comment:1 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10919]) WPFS cleanups. Props DD32. fixes #9525

comment:3 @ryan6 years ago

(In [10930]) Revert FTP parts of [10919]. fixes #9535 see #9525

Note: See TracTickets for help on using tickets.