WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#9527 closed enhancement (fixed)

Manage Plugins page layout changes

Reported by: arena Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: UI Keywords:
Focuses: Cc:

Description

Could it be possible to have the Plugins page changed to fit the 2.7 list design ?

Attachments (8)

plugins.jpg (166.6 KB) - added by arena 5 years ago.
Screenshot of the new plugins list
9527.diff (3.6 KB) - added by ryan 5 years ago.
9527.2.diff (5.1 KB) - added by ShaneF 5 years ago.
9527.3.diff (3.4 KB) - added by DD32 5 years ago.
Paging
9527.4.diff (5.9 KB) - added by DD32 5 years ago.
Paging + Searching based on stripos
9527.5.diff (6.0 KB) - added by DD32 5 years ago.
Paging + Searching based on stripos
9527.6.diff (6.1 KB) - added by DD32 5 years ago.
9527-plugin.php.diff (1.1 KB) - added by mtekk 5 years ago.
Fixes the broken All link since we now remember the last active page

Download all attachments as: .zip

Change History (44)

arena5 years ago

Screenshot of the new plugins list

comment:1 janeforshort5 years ago

  • Component changed from Administration to UI
  • Owner anonymous deleted
  • Priority changed from high to normal
  • Version set to 2.8

Makes sense. We just never got around to this screen.

ryan5 years ago

comment:2 ryan5 years ago

There's a start. The name column needs a min width or something so that the actions don't wrap when the table contains only plugins with short names.

comment:3 Denis-de-Bernardy5 years ago

  • Keywords has-patch tested added
  • Milestone changed from Unassigned to 2.8

looks neat with the patch. imo the actions links shouldn't be bold, though.

comment:4 ShaneF5 years ago

  • Keywords commit added

Made it so the action links are not bold and made it so it doesn't wrap.

ShaneF5 years ago

comment:5 ryan5 years ago

Included in [10978]. We might be changing things some more, so let's leave this open.

comment:6 arena5 years ago

Really nice job ! some adjustements and it will be perfect !

In the picture attached, you can notice that :

  • 'subsubsub' : list can be filtered by the plugin statuses (All, Active, Recently active, Inactive).
  • 'search box' : list can be filtered with a search box for sites using a long list of plugins
  • there is only one list (still two lists in the patch)

you cannot notice that :

  • 'contextual_help' : the trailer text "Get More Plugins ..." should be moved in the help tab.
  • the picture didn't mention the pagination ...

comment:7 ryan5 years ago

(In [10999]) Add plugin filter by status. Move help verbage to contextual help. see #9527

comment:8 ryan5 years ago

If anyone wants to implement search and paging, have a go.

comment:9 ryan5 years ago

A filter that would be handy: "Upgrade Available" or "Needs Upgrade"

comment:10 ryan5 years ago

(In [11000]) Add filter showing all plugins that have an upgrade available. see #9527

comment:11 ryan5 years ago

(In [11001]) Move leader text to contextual help. see #9527

DD325 years ago

Paging

DD325 years ago

Paging + Searching based on stripos

DD325 years ago

Paging + Searching based on stripos

comment:12 DD325 years ago

attachment 9527.5.diff added

  • Paging
  • Searching based on stripos
    • Searches the metadata in what i thought was the most likely order for the phrase to be found
    • from .4: Changed it to match strings at the start of the metadata
    • Probably isnt the best way to go about it really.

The table also needs Bulk actions adding to the bottom of it.

About to add another patch which fixes the Plugin Home link & Author display on the description, But the patch will conflict with #9573, Might be best to commit that first, or commit .5 while waiting for #9573 to be dealt with.

DD325 years ago

comment:13 DD325 years ago

attachment 9527.6.diff added

  • Doesnt have the patch conflict, Use this over .4 or .5
  • #9527 still needs to be commited though :P

comment:14 arena5 years ago

Great !

do not know if it is still a bug,

in last trunk :

Active and Inactive filtered lists work fine,
but for All list, unable to deactivate a plugin, only activate option available,
i believe plugin status should be tested to retrieve the right text and link (Activate/Deactivate)

comment:15 arena5 years ago

+ global actions and item list actions should be the same for the different type of statuses lists.

comment:16 ryan5 years ago

(In [11003]) Plugin search and paging. Props DD32. see #9527

comment:17 ryan5 years ago

(In [11004]) Show actions based on plugin active status. see #9527

comment:18 ryan5 years ago

We need a per page screen option as with the other manage screens.

comment:19 ryan5 years ago

Force ftp so I could the connection screen. I see two h2s: "Upgrade Plugin" and "Connection Information".

Installs and upgrades using direct went off without a hitch.

comment:20 follow-up: ryan5 years ago

Ignore the above, wrong ticket. :-)

comment:21 in reply to: ↑ 20 arena5 years ago

Just fine,

agree with ryan about the screen option

and
on ALL list, global actions do not have the deactivate option

comment:22 arena5 years ago

and on Search Results list, global actions do not have the deactivate option

comment:23 ryan5 years ago

(In [11014]) Fix bulk action lists. see #9527

comment:24 ryan5 years ago

(In [11027]) Add per page screen option to plugins page. see #9527

comment:25 Denis-de-Bernardy5 years ago

  • Keywords has-patch commit tested removed

we've UI problems... the active plugins should be the default filter imo

also, when you bulk deactivate plugins, from the active plugins, you return to the list of all plugins, rather than to the list of active plugins. presumably the same occurs when you bulk activate the plugins from the deactivated list. if pagination weren't around, btw, I might expect the latter to redirect me to the recently active plugins list and to the active plugins list, respectively. (worth asking Jane.)

the pagination was a very bad idea imo, or then it should be increased to 50 items at the very least. when you've several pages of plugins it's a mess to mass-activate or disable them, or when you need to get a clear picture of what's active.

as it stands, disabling all plugins looks like this:

  • browse active plugins (because you otherwise get tons of unnecessary things)
  • select all, deactivate
  • get redirected to all plugins
  • browse active plugins again
  • select all, deactivate
  • and again... as many times as needed (in my case two more)...

needing to do this kind of thing happens quite often, when you need to debug a site. the first thing I usually do when a customer reports a bug is to disable all plugins I didn't author -- in which case he gets to fix his own site. pagination turns this otherwise simple task (check check check, click button) into a real burden. picture plugins 19-25 out of a list of 40 needing to be disabled: you end up disabling them one by one, not to mention the redirect problems highlighted above.

comment:26 automattor5 years ago

(In [11029]) Remember status and page when redirecting. see #9527

comment:27 ryan5 years ago

Redirects fixed. The number of plugins per page can be changed via screen options.

comment:28 ryan5 years ago

We could remember the last status filter (all, active, inactive, etc.) used and return to that when visiting plugins.php with no plugin_status set. Or, add a screen option for setting the default filter.

comment:29 Denis-de-Bernardy5 years ago

+1 to remembering the status, always.

comment:30 ryan5 years ago

(In [11034]) Remember last view for plugins page. see #9527

mtekk5 years ago

Fixes the broken All link since we now remember the last active page

comment:31 mtekk5 years ago

In the last commit by ryan the All link was broken, see my patch "9527-plugin.php.diff" for a fix.

comment:33 Denis-de-Bernardy5 years ago

when you do a search, it remembers the status too. it would be sweet if it remembered the search string too, else it shouldn't store that status. :-)

comment:34 ryan5 years ago

(In [11055]) Don't remember search in last view. see #9527

comment:35 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:36 nacin3 years ago

Followup UX changes (removal of plugins_last_view): #18810.

Note: See TracTickets for help on using tickets.