WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9537 closed enhancement (wontfix)

disabled buttons do not look disabled

Reported by: jbsil Owned by: azaozz
Milestone: 2.9 Priority: lowest
Severity: trivial Version: 2.7
Component: UI Keywords: needs-patch
Focuses: Cc:

Description

The button gradients for button, button-secondary and button-primary all invert on :active. This gives the user the impression that the button still can be clicked because, when the button is clicked, it still changes and looks as though it is being clicked in.

The :disabled state for any of the three button classes does not include a background parameter, and the :active state's background parameter is listed as !important.

I think the :disabled state should be more apparent to the user so that the button does not seem clickable. Maybe

button:disabled, button-secondary:disabled, button-primary:disabled {
     background: #ccc !important;
}

or something along those lines. And possibly remove the !important from the :active states.

This needs to be changed in both colors-fresh.css and colors-classic.css

Attachments (1)

9537.disabled.diff (2.3 KB) - added by jbsil 5 years ago.
first stab at :disabled buttons that actually look disabled. changed some colors, backgrounds and !importants in :active, :disabled and :hover

Download all attachments as: .zip

Change History (8)

jbsil5 years ago

first stab at :disabled buttons that actually look disabled. changed some colors, backgrounds and !importants in :active, :disabled and :hover

comment:1 jbsil5 years ago

  • Keywords dev-feedback 2nd-opinion has-patch added
  • Summary changed from disabled buttons still "press" when clicked to disabled buttons do not look disabled

Patch for the two css files that need to be changed.

comment:2 jbsil5 years ago

  • Milestone changed from Unassigned to 2.8

comment:3 ryan5 years ago

  • Component changed from Administration to UI
  • Owner changed from anonymous to azaozz

comment:4 Denis-de-Bernardy5 years ago

  • Keywords dev-feedback 2nd-opinion removed

isn't removing the !important on the likes of #login form .submit input:active wrong?

comment:5 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.8 to Future Release

patch is b0rke

comment:6 Denis-de-Bernardy5 years ago

  • Milestone changed from Future Release to 2.9

comment:7 azaozz5 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

The patch doesn't cover all cases too. Also the buttons change enough I think. If they change more, they start to draw too much attention when the Submit postbox is next to the editor (the buttons there are disabled every 2 min. while autosave is running).

Note: See TracTickets for help on using tickets.