Opened 16 years ago
Closed 16 years ago
#9556 closed enhancement (fixed)
Packaged themes should make use of comments_open() and pings_open()
Reported by: | coffee2code | Owned by: | |
---|---|---|---|
Milestone: | 2.8 | Priority: | low |
Severity: | minor | Version: | 2.7.1 |
Component: | Themes | Keywords: | has-patch |
Focuses: | Cc: |
Description
Since comments_open()
and pings_open()
have been around for awhile, the packaged themes should make use of them instead of doing something like 'open' == $post->comment_status
. The latter is exposes too much internal workings and is not filterable.
The comments.php file for the classic theme makes use of these calls, but classic/comments-popup.php does not. And for the default theme, neither comments.php nor comments-popup.php make use of the functions.
The attached patch modifies those three theme files to make use of comments_open()
and pings_open()
where appropriate.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
I've replaced my original diff with an amended version that also makes the
comments_open()
andpings_open()
change to the default theme's image.php and single.php files. That should round things out.