WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9557 closed enhancement (fixed)

comment-template.php and xmlrpc.php should make use of comments_open()

Reported by: coffee2code Owned by:
Milestone: 2.8 Priority: low
Severity: minor Version: 2.7.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

comments_popup_link() in wp-includes/comment-template.php uses the old-style check:

'closed' == $post->comment_status && 'closed' == $post->ping_status

rather than the modern:

!comments_open() && !pings_open()

get_comment_reply_link() also uses the old-style check for comment_status.

xmlrpc.php also has a place where the old-style check for comment_status and ping_status should instead be comments_open() and pings_open().

Attachments (1)

bug9557.use_comments_open.diff (1.3 KB) - added by coffee2code 5 years ago.
Aforementioned patch

Download all attachments as: .zip

Change History (2)

coffee2code5 years ago

Aforementioned patch

comment:1 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10982]) Use comments_open() and pings_open(). Props coffee2code. fixes #9557

Note: See TracTickets for help on using tickets.