do_action sequence in admin-footer.php

[arena]

the current sequence is :
do_action('admin_footer', );
do_action('admin_print_footer_scripts');
do_action("admin_footer-$hook_suffix");

shouldn't it be

do_action("admin_footer-$hook_suffix");
do_action('admin_print_footer_scripts');
do_action('admin_footer', );

[Viper007Bond]

Yes, the generic hook should come last. Attached patch matches the order of the header.

[arena]

Sorry but the right sequence should be :

do_action("admin_footer-$hook_suffix");
do_action('admin_print_footer_scripts');
do_action('admin_footer', );

[Viper007Bond]

Erm, why? I went off the order that the header has it in:

do_action('admin_enqueue_scripts', $hook_suffix);
do_action("admin_print_styles-$hook_suffix");
do_action('admin_print_styles');
do_action("admin_print_scripts-$hook_suffix");
do_action('admin_print_scripts');
do_action("admin_head-$hook_suffix");
do_action('admin_head');

[arena]

Replying to Viper007Bond:

Erm, why? I went off the order that the header has it in:

do_action('admin_enqueue_scripts', $hook_suffix);
do_action("admin_print_styles-$hook_suffix");
do_action('admin_print_styles');
do_action("admin_print_scripts-$hook_suffix");
do_action('admin_print_scripts');
do_action("admin_head-$hook_suffix");
do_action('admin_head');

ok !

[arena]

Anyone to commit this patch ? thank you !

[Denis-de-Bernardy]

If I add a script in one particular page to override WP scripts, I'd *much* rather than the hook-specific hook fires after, personally.

[azaozz]

In the footer scripts have to be printed after all content, just before the </body> tag. Also as Denis mentions running do_action("admin_footer-$hook_suffix"); last allows overwriting any previously defined js function.